mirror/Part-DB.Part-DB-server
1
0
Fork 1
mirror of https://github.com/Part-DB/Part-DB-server.git synced 2025-07-09 01:44:31 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improved attachment name generation from DTO url

Browse source 
We dont include the query paramaters in the name anymore
This commit is contained in:
Jan Böhmer 2023-07-29 18:38:18 +02:00
parent 11be65678e
commit 1c222ff293
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/Services/InfoProviderSystem/DTOtoEntityConverter.php
View file

@ -130,7 +130,7 @@ final class DTOtoEntityConverter
//If no name is given, try to extract the name from the URL //If no name is given, try to extract the name from the URL
if (empty($dto->name)) { if (empty($dto->name)) {
$entity->setName(basename($dto->url)); $entity->setName($this->getAttachmentNameFromURL($dto->url));
} else { } else {
$entity->setName($dto->name); $entity->setName($dto->name);
} }
@ -138,6 +138,11 @@ final class DTOtoEntityConverter
return $entity; return $entity;
} }
private function getAttachmentNameFromURL(string $url): string
{
return basename(parse_url($url, PHP_URL_PATH));
}
/** /**
* Converts a PartDetailDTO to a Part entity * Converts a PartDetailDTO to a Part entity
* @param PartDetailDTO $dto * @param PartDetailDTO $dto