From 1becde537b250c310cbd409f028a3db1db05d56a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20B=C3=B6hmer?= Date: Sun, 8 Oct 2023 21:54:51 +0200 Subject: [PATCH] Fixed test issues --- src/DataTables/Helpers/ColumnSortHelper.php | 5 ++--- src/DataTables/PartsDataTable.php | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/DataTables/Helpers/ColumnSortHelper.php b/src/DataTables/Helpers/ColumnSortHelper.php index a16a64d8..c61ad6ce 100644 --- a/src/DataTables/Helpers/ColumnSortHelper.php +++ b/src/DataTables/Helpers/ColumnSortHelper.php @@ -30,9 +30,8 @@ class ColumnSortHelper { private array $columns = []; - public function __construct(LoggerInterface $logger) + public function __construct(private readonly LoggerInterface $logger) { - $this->logger = $logger; } /** @@ -111,7 +110,7 @@ class ColumnSortHelper //and the remaining non-visible columns foreach ($this->columns as $col_id => $col_data) { - if (in_array($col_id, $processed_columns)) { + if (in_array($col_id, $processed_columns, true)) { // column already processed continue; } diff --git a/src/DataTables/PartsDataTable.php b/src/DataTables/PartsDataTable.php index 3042a3c9..1718ca7c 100644 --- a/src/DataTables/PartsDataTable.php +++ b/src/DataTables/PartsDataTable.php @@ -255,7 +255,7 @@ final class PartsDataTable implements DataTableTypeInterface "TABLE_PARTS_DEFAULT_COLUMNS"); $dataTable->addOrderBy('name') - ->createAdapter(TwoStepORMAdapater::class, [ + ->createAdapter(TwoStepORMAdapter::class, [ 'filter_query' => $this->getFilterQuery(...), 'detail_query' => $this->getDetailQuery(...), 'entity' => Part::class,