From 19819454fa6e1f3c18a992269ef2af5949eee1a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20B=C3=B6hmer?= Date: Sat, 6 Jan 2024 15:12:04 +0100 Subject: [PATCH] Dont split up links when extracting parameters from notes and description This partly fixes issue #469 --- src/Services/Parameters/ParameterExtractor.php | 2 +- tests/Services/Parameters/ParameterExtractorTest.php | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Services/Parameters/ParameterExtractor.php b/src/Services/Parameters/ParameterExtractor.php index 9eaf946a..a133b282 100644 --- a/src/Services/Parameters/ParameterExtractor.php +++ b/src/Services/Parameters/ParameterExtractor.php @@ -88,7 +88,7 @@ class ParameterExtractor protected function stringToParam(string $input, string $class): ?AbstractParameter { $input = trim($input); - $regex = '/^(.*) *(?:=|:) *(.+)/u'; + $regex = '/^(.*) *(?:=|:)(?!\/) *(.+)/u'; $matches = []; preg_match($regex, $input, $matches); diff --git a/tests/Services/Parameters/ParameterExtractorTest.php b/tests/Services/Parameters/ParameterExtractorTest.php index e82d99af..842f8b80 100644 --- a/tests/Services/Parameters/ParameterExtractorTest.php +++ b/tests/Services/Parameters/ParameterExtractorTest.php @@ -67,6 +67,7 @@ class ParameterExtractorTest extends WebTestCase ['=BC547 rewr'], ['For good, [b]bad[/b], evil'], ['Param:; Test'], + ['A [link](https://demo.part-db.de) should not be matched'] ]; }