mirror/Part-DB.Part-DB-server
1
0
Fork 1
mirror of https://github.com/Part-DB/Part-DB-server.git synced 2025-06-21 17:39:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixed some inspection issues.

Browse source
This commit is contained in:
Jan Böhmer 2019-08-20 18:39:57 +02:00
parent 8e23629dc0
commit 1629f31fed
31 changed files with 187 additions and 211 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/Controller/AttachmentFileController.php
View file

@ -47,17 +47,20 @@ class AttachmentFileController extends AbstractController
*
* @Route("/attachment/{id}/download", name="attachment_download")
* @param Attachment $attachment
* @param AttachmentHelper $helper
* @return BinaryFileResponse
* @throws \Exception
*/
public function download(Attachment $attachment, AttachmentHelper $helper)
{
$this->denyAccessUnlessGranted("read", $attachment);
$this->denyAccessUnlessGranted('read', $attachment);
if ($attachment->isExternal()) {
throw new \Exception("You can not download external attachments!");
throw new \RuntimeException('You can not download external attachments!');
}
if (!$helper->isFileExisting($attachment)) {
throw new \Exception("The file associated with the attachment is not existing!");
throw new \RuntimeException('The file associated with the attachment is not existing!');
}
@ -75,17 +78,20 @@ class AttachmentFileController extends AbstractController
*
* @Route("/attachment/{id}/view", name="attachment_view")
* @param Attachment $attachment
* @param AttachmentHelper $helper
* @return BinaryFileResponse
* @throws \Exception
*/
public function view(Attachment $attachment, AttachmentHelper $helper)
{
$this->denyAccessUnlessGranted("read", $attachment);
$this->denyAccessUnlessGranted('read', $attachment);
if ($attachment->isExternal()) {
throw new \Exception("You can not download external attachments!");
throw new \RuntimeException('You can not download external attachments!');
}
if (!$helper->isFileExisting($attachment)) {
throw new \Exception("The file associated with the attachment is not existing!");
throw new \RuntimeException('The file associated with the attachment is not existing!');
}