Forbid access to homepage if a user has no allow permission

This allows to block access to everything (even the homepage) for anonymous access. This fixes issue #290

src/Controller/HomepageController.php

@@ -66,6 +66,8 @@ class HomepageController extends AbstractController
     public function homepage(Request $request, GitVersionInfo $versionInfo, EntityManagerInterface $entityManager,
     UpdateAvailableManager $updateAvailableManager): Response
     {
+        $this->denyAccessUnlessGranted('HAS_ACCESS_PERMISSIONS');
+
         if ($this->isGranted('@tools.lastActivity')) {
             $table = $this->dataTable->createFromType(
                 LogDataTable::class,

src/Security/Voter/HasAccessPermissionsVoter.php

@@ -0,0 +1,45 @@
+<?php
+/*
+ * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
+ *
+ *  Copyright (C) 2019 - 2023 Jan Böhmer (https://github.com/jbtronics)
+ *
+ *  This program is free software: you can redistribute it and/or modify
+ *  it under the terms of the GNU Affero General Public License as published
+ *  by the Free Software Foundation, either version 3 of the License, or
+ *  (at your option) any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU Affero General Public License for more details.
+ *
+ *  You should have received a copy of the GNU Affero General Public License
+ *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
+
+declare(strict_types=1);
+
+
+namespace App\Security\Voter;
+
+use App\Entity\UserSystem\User;
+
+/**
+ * This voter implements a virtual role, which can be used if the user has any permission set to allowed.
+ * We use this to restrict access to the homepage.
+ */
+class HasAccessPermissionsVoter extends ExtendedVoter
+{
+    public const ROLE = "HAS_ACCESS_PERMISSIONS";
+
+    protected function voteOnUser(string $attribute, $subject, User $user): bool
+    {
+        return $this->resolver->hasAnyPermissionSetToAllowInherited($user);
+    }
+
+    protected function supports(string $attribute, mixed $subject): bool
+    {
+        return $attribute === self::ROLE;
+    }
+}

src/Services/UserSystem/PermissionManager.php

@@ -271,6 +271,27 @@ class PermissionManager
         }
     }
 
+    /**
+     * This function checks if the given user has any permission set to allow, either directly or inherited.
+     * @param  User  $user
+     * @return bool
+     */
+    public function hasAnyPermissionSetToAllowInherited(User $user): bool
+    {
+        //Iterate over all permissions
+        foreach ($this->permission_structure['perms'] as $perm_key => $permission) {
+            //Iterate over all operations of the permission
+            foreach ($permission['operations'] as $op_key => $op) {
+                //Check if the user has the permission set to allow
+                if ($this->inherit($user, $perm_key, $op_key) === true) {
+                    return true;
+                }
+            }
+        }
+
+        return false;
+    }
+
     protected function generatePermissionStructure()
     {
         $cache = new ConfigCache($this->cache_file, $this->kernel_debug_enabled);

tests/Services/UserSystem/PermissionManagerTest.php

@@ -31,15 +31,12 @@ use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 
 class PermissionManagerTest extends WebTestCase
 {
-    protected $user_withoutGroup;
+    protected ?User $user_withoutGroup = null;
 
-    protected $user;
-    protected $group;
+    protected ?User $user = null;
+    protected ?Group $group = null;
 
-    /**
-     * @var PermissionManager
-     */
-    protected $service;
+    protected ?PermissionManager $service = null;
 
     protected function setUp(): void
     {
@@ -294,4 +291,34 @@ class PermissionManagerTest extends WebTestCase
         $this->assertTrue($this->service->dontInherit($user, 'parts', 'edit'));
         $this->assertTrue($this->service->dontInherit($user, 'categories', 'read'));
     }
+
+    public function testHasAnyPermissionSetToAllowInherited(): void
+    {
+        //For empty user this should return false
+        $user = new User();
+        $this->assertFalse($this->service->hasAnyPermissionSetToAllowInherited($user));
+
+        //If all permissions are set to false this should return false
+        $this->service->setAllPermissions($user, false);
+        $this->assertFalse($this->service->hasAnyPermissionSetToAllowInherited($user));
+
+        //If all permissions are set to null this should return false
+        $this->service->setAllPermissions($user, null);
+        $this->assertFalse($this->service->hasAnyPermissionSetToAllowInherited($user));
+
+        //If all permissions are set to true this should return true
+        $this->service->setAllPermissions($user, true);
+        $this->assertTrue($this->service->hasAnyPermissionSetToAllowInherited($user));
+
+        //The test data should return true
+        $this->assertTrue($this->service->hasAnyPermissionSetToAllowInherited($this->user));
+        $this->assertTrue($this->service->hasAnyPermissionSetToAllowInherited($this->user_withoutGroup));
+
+        //Create a user with a group
+        $user = new User();
+        $user->setGroup($this->group);
+        //This should return true
+        $this->assertTrue($this->service->hasAnyPermissionSetToAllowInherited($user));
+
+    }
 }