From 0dcdd252f5130ab17d541ef003606e26027612f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20B=C3=B6hmer?= Date: Sun, 16 Apr 2023 00:55:25 +0200 Subject: [PATCH] Fixed static analysis issues --- src/Controller/LogController.php | 2 +- src/EventSubscriber/UserSystem/LoginSuccessSubscriber.php | 1 - .../UserSystem/PasswordChangeNeededSubscriber.php | 2 +- .../UserSystem/UpgradePermissionsSchemaSubscriber.php | 1 - 4 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/Controller/LogController.php b/src/Controller/LogController.php index 3c28fa99..de5d3c17 100644 --- a/src/Controller/LogController.php +++ b/src/Controller/LogController.php @@ -52,7 +52,7 @@ class LogController extends AbstractController { protected EntityManagerInterface $entityManager; protected TimeTravel $timeTravel; - protected EntityRepository $dbRepository; + protected DBElementRepository $dbRepository; public function __construct(EntityManagerInterface $entityManager, TimeTravel $timeTravel) { diff --git a/src/EventSubscriber/UserSystem/LoginSuccessSubscriber.php b/src/EventSubscriber/UserSystem/LoginSuccessSubscriber.php index 0587ff29..cce88d82 100644 --- a/src/EventSubscriber/UserSystem/LoginSuccessSubscriber.php +++ b/src/EventSubscriber/UserSystem/LoginSuccessSubscriber.php @@ -44,7 +44,6 @@ final class LoginSuccessSubscriber implements EventSubscriberInterface public function __construct(TranslatorInterface $translator, RequestStack $requestStack, EventLogger $eventLogger, bool $gpdr_compliance) { - /** @var Session $session */ $this->translator = $translator; $this->requestStack = $requestStack; $this->eventLogger = $eventLogger; diff --git a/src/EventSubscriber/UserSystem/PasswordChangeNeededSubscriber.php b/src/EventSubscriber/UserSystem/PasswordChangeNeededSubscriber.php index 11c081b4..ef7da6a9 100644 --- a/src/EventSubscriber/UserSystem/PasswordChangeNeededSubscriber.php +++ b/src/EventSubscriber/UserSystem/PasswordChangeNeededSubscriber.php @@ -110,7 +110,7 @@ final class PasswordChangeNeededSubscriber implements EventSubscriberInterface } if (static::TFARedirectNeeded($user)) { - $this->flashBag->add('warning', 'user.2fa_needed.flash'); + $flashBag->add('warning', 'user.2fa_needed.flash'); } $event->setResponse($this->httpUtils->createRedirectResponse($request, static::REDIRECT_TARGET)); diff --git a/src/EventSubscriber/UserSystem/UpgradePermissionsSchemaSubscriber.php b/src/EventSubscriber/UserSystem/UpgradePermissionsSchemaSubscriber.php index b38f0dfe..1d03cb83 100644 --- a/src/EventSubscriber/UserSystem/UpgradePermissionsSchemaSubscriber.php +++ b/src/EventSubscriber/UserSystem/UpgradePermissionsSchemaSubscriber.php @@ -42,7 +42,6 @@ class UpgradePermissionsSchemaSubscriber implements EventSubscriberInterface public function __construct(Security $security, PermissionSchemaUpdater $permissionSchemaUpdater, EntityManagerInterface $entityManager, EventCommentHelper $eventCommentHelper) { - /** @var Session $session */ $this->security = $security; $this->permissionSchemaUpdater = $permissionSchemaUpdater; $this->entityManager = $entityManager;