From 09995330af4852b46370e487ad989b3fafe94d79 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20B=C3=B6hmer?= Date: Sun, 10 Nov 2019 19:58:35 +0100 Subject: [PATCH] Fixed an exception on part tables, when an attachment is external. --- assets/css/tagsinput.css | 3 ++- src/DataTables/Column/PartAttachmentsColumn.php | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/assets/css/tagsinput.css b/assets/css/tagsinput.css index 09900961..e3ff2c34 100644 --- a/assets/css/tagsinput.css +++ b/assets/css/tagsinput.css @@ -1,6 +1,7 @@ /* * bootstrap-tagsinput v0.8.0 - * + * Modified by Jan Böhmer 2019 + * (Added some margin between the tags. */ .bootstrap-tagsinput { diff --git a/src/DataTables/Column/PartAttachmentsColumn.php b/src/DataTables/Column/PartAttachmentsColumn.php index d7ccddd3..661f5a89 100644 --- a/src/DataTables/Column/PartAttachmentsColumn.php +++ b/src/DataTables/Column/PartAttachmentsColumn.php @@ -38,7 +38,7 @@ class PartAttachmentsColumn extends AbstractColumn protected $FAIconGenerator; protected $urlGenerator; - public function __construct(FAIconGenerator $FAIconGenerator, AttachmentURLGenerator $urlGenerator) + public function __construct(FAIconGenerator $FAIconGenerator, EntityURLGenerator $urlGenerator) { $this->FAIconGenerator = $FAIconGenerator; $this->urlGenerator = $urlGenerator; @@ -74,7 +74,7 @@ class PartAttachmentsColumn extends AbstractColumn /** @var Attachment $attachment */ $tmp .= sprintf( '%s', - $this->urlGenerator->getViewURL($attachment), + $this->urlGenerator->viewURL($attachment), htmlspecialchars($attachment->getName()) . ': ' . htmlspecialchars($attachment->getFilename()), $this->FAIconGenerator->generateIconHTML( $this->FAIconGenerator->fileExtensionToFAType($attachment->getExtension()),