From 05ab3c3b7b6e8e760eda3634a8e06324f82423c4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20B=C3=B6hmer?= <mail@jan-boehmer.de>
Date: Mon, 20 Feb 2023 00:24:12 +0100
Subject: [PATCH] Fixed image display style for odd shaped (very small) images.

---
 assets/css/app/images.css                      | 15 +++++++++++++++
 src/DataTables/Helpers/PartDataTableHelper.php |  2 +-
 templates/parts/info/_picture.html.twig        |  2 +-
 templates/projects/info/_info.html.twig        |  4 ++--
 4 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/assets/css/app/images.css b/assets/css/app/images.css
index 51760058..9168484d 100644
--- a/assets/css/app/images.css
+++ b/assets/css/app/images.css
@@ -46,4 +46,19 @@
     height: 1.5em;
     max-width: 2.0em;
     object-fit: contain;
+}
+
+.part-table-image {
+    max-height: 40px;
+    object-fit: contain;
+    width: 100%;
+}
+
+.part-info-image {
+    max-height: 350px;
+    object-fit: contain;
+}
+
+.object-fit-cover {
+    object-fit: cover;
 }
\ No newline at end of file
diff --git a/src/DataTables/Helpers/PartDataTableHelper.php b/src/DataTables/Helpers/PartDataTableHelper.php
index 90255835..c9000283 100644
--- a/src/DataTables/Helpers/PartDataTableHelper.php
+++ b/src/DataTables/Helpers/PartDataTableHelper.php
@@ -88,7 +88,7 @@ class PartDataTableHelper
             'Part image',
             $this->attachmentURLGenerator->getThumbnailURL($preview_attachment),
             $this->attachmentURLGenerator->getThumbnailURL($preview_attachment, 'thumbnail_md'),
-            'img-fluid hoverpic',
+            'hoverpic part-table-image',
             $title
         );
     }
diff --git a/templates/parts/info/_picture.html.twig b/templates/parts/info/_picture.html.twig
index 29ea936e..90c99c86 100644
--- a/templates/parts/info/_picture.html.twig
+++ b/templates/parts/info/_picture.html.twig
@@ -12,7 +12,7 @@
                 {# @var pic App\Entity\Attachments\Attachment #}
                 <div class="carousel-item  {% if loop.first %}active{% endif %}">
                     <a href="{{ entity_url(pic, 'file_view') }}" data-turbo="false" target="_blank" rel="noopener">
-                        <img class="d-block w-100 img-fluid img-thumbnail bg-light" src="{{ entity_url(pic, 'file_view') }}" alt="">
+                        <img class="d-block w-100 img-fluid img-thumbnail bg-light part-info-image" src="{{ entity_url(pic, 'file_view') }}" alt="">
                         <div class="mask"></div>
                         <div class="carousel-caption-hover">
                             <div class="carousel-caption">
diff --git a/templates/projects/info/_info.html.twig b/templates/projects/info/_info.html.twig
index c2d36d67..546c433b 100644
--- a/templates/projects/info/_info.html.twig
+++ b/templates/projects/info/_info.html.twig
@@ -6,10 +6,10 @@
             <div class="col-md-3 col-lg-4 col-4 mt-auto mb-auto">
                 {% if project.masterPictureAttachment %}
                     <a href="{{ entity_url(project.masterPictureAttachment, 'file_view') }}" data-turbo="false" target="_blank" rel="noopener">
-                        <img class="d-block w-100 img-fluid img-thumbnail bg-light" src="{{ entity_url(project.masterPictureAttachment, 'file_view') }}" alt="">
+                        <img class="d-block w-100 img-fluid img-thumbnail bg-light part-info-image" src="{{ entity_url(project.masterPictureAttachment, 'file_view') }}" alt="">
                     </a>
                 {% else %}
-                    <img src="{{ asset('img/part_placeholder.svg') }}" class="img-fluid img-thumbnail bg-light mb-2" alt="Part main image" height="300" width="300">
+                    <img src="{{ asset('img/part_placeholder.svg') }}" class="img-fluid img-thumbnail bg-light mb-2 " alt="Part main image" height="300" width="300">
                 {% endif %}
             </div>
             <div class="col-md-9 col-lg-8 col-7">