add check mode the ip neighbor

This commit is contained in:
Valentin Gurmeza 2017-06-05 14:06:50 -07:00
parent 2e9470d232
commit 5c57fdccad
2 changed files with 67 additions and 58 deletions

View file

@ -55,64 +55,65 @@ from ansible.module_utils.basic import AnsibleModule
def main(): def main():
module = AnsibleModule( module = AnsibleModule(
argument_spec = dict( argument_spec = dict(
hostname = dict(required=True), hostname = dict(required=True),
username = dict(required=True), username = dict(required=True),
password = dict(required=True), password = dict(required=True),
settings = dict(required=False, type='dict'), settings = dict(required=False, type='dict'),
parameter = dict( parameter = dict(
required = True, required = True,
choices = ['discovery'], choices = ['discovery'],
type = 'str' type = 'str'
), ),
state = dict( state = dict(
required = False, required = False,
choices = ['present', 'absent'], choices = ['present', 'absent'],
type = 'str' type = 'str'
), ),
) ),
supports_check_mode=True
)
idempotent_parameter = None
params = module.params
idempotent_parameter = 'name'
mt_obj = MikrotikIdempotent(
hostname = params['hostname'],
username = params['username'],
password = params['password'],
state = params['state'],
desired_params = params['settings'],
idempotent_param = idempotent_parameter,
api_path = '/ip/neighbor/' + str(params['parameter']),
check_mode = module.check_mode
)
mt_obj.sync_state()
if mt_obj.failed:
module.fail_json(
msg = mt_obj.failed_msg
) )
elif mt_obj.changed:
idempotent_parameter = None module.exit_json(
params = module.params failed=False,
idempotent_parameter = 'name' changed=True,
msg=mt_obj.changed_msg,
diff={ "prepared": {
mt_obj = MikrotikIdempotent( "old": mt_obj.old_params,
hostname = params['hostname'], "new": mt_obj.new_params,
username = params['username'], }},
password = params['password'], )
state = params['state'], else:
desired_params = params['settings'], module.exit_json(
idempotent_param = idempotent_parameter, failed=False,
api_path = '/ip/neighbor/' + str(params['parameter']), changed=False,
#msg='',
msg=params['settings'],
) )
mt_obj.sync_state()
if mt_obj.failed:
module.fail_json(
msg = mt_obj.failed_msg
)
elif mt_obj.changed:
module.exit_json(
failed=False,
changed=True,
msg=mt_obj.changed_msg,
diff={ "prepared": {
"old": mt_obj.old_params,
"new": mt_obj.new_params,
}},
)
else:
module.exit_json(
failed=False,
changed=False,
#msg='',
msg=params['settings'],
)
if __name__ == '__main__': if __name__ == '__main__':
main() main()

View file

@ -1984,7 +1984,11 @@
name: ether2 name: ether2
discover: "no" discover: "no"
register: discovery_edit register: discovery_edit
failed_when: ( discovery_edit | changed ) failed_when: (
not ansible_check_mode
) and (
( discovery_edit | changed )
)
- name: ALWAYS_CHANGES edit a interface discovery option - name: ALWAYS_CHANGES edit a interface discovery option
mt_neighbor: mt_neighbor:
@ -1996,7 +2000,11 @@
name: ether2 name: ether2
discover: "yes" discover: "yes"
register: discovery_edit register: discovery_edit
failed_when: not ( discovery_edit | changed ) failed_when: (
not ansible_check_mode
) and (
not ( discovery_edit | changed )
)
tags: neighbor tags: neighbor