mirror.MikroTik/tomaae.homeassistant-mikrotik_router
1
0
Fork 0
mirror of https://github.com/tomaae/homeassistant-mikrotik_router.git synced 2025-07-05 06:54:29 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

log disconnect error/retry only once until reconnect

Browse source 
log reconnect
This commit is contained in:
tomaae 2020-03-17 00:40:08 +01:00
parent 8ec4f9ade5
commit 50cf54c417
1 changed files with 87 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

120
custom_components/mikrotik_router/mikrotikapi.py
View file

@ -47,6 +47,7 @@ class MikrotikAPI:
self._connection_epoch = 0 self._connection_epoch = 0
self._connection_retry_sec = 58 self._connection_retry_sec = 58
self.error = None self.error = None
self.connection_error_reported = False
# Default ports # Default ports
if not self._port: if not self._port:
@ -98,22 +99,33 @@ class MikrotikAPI:
BrokenPipeError, BrokenPipeError,
OSError, OSError,
) as api_error: ) as api_error:
_LOGGER.error( if not self.connection_error_reported:
"Mikrotik %s error while connecting: %s", self._host, api_error _LOGGER.error(
) "Mikrotik %s error while connecting: %s", self._host, api_error
)
self.connection_error_reported = True
self.error_to_strings("%s" % api_error) self.error_to_strings("%s" % api_error)
self._connection = None self._connection = None
self.lock.release() self.lock.release()
return False return False
except: except:
_LOGGER.error( if not self.connection_error_reported:
"Mikrotik %s error while connecting: %s", self._host, "Unknown" _LOGGER.error(
) "Mikrotik %s error while connecting: %s", self._host, "Unknown"
)
self.connection_error_reported = True
self._connection = None self._connection = None
self.lock.release() self.lock.release()
return False return False
else: else:
_LOGGER.debug("Mikrotik Connected to %s", self._host) if self.connection_error_reported:
_LOGGER.warning("Mikrotik Reconnected to %s", self._host)
self.connection_error_reported = False
else:
_LOGGER.debug("Mikrotik Connected to %s", self._host)
self._connected = True self._connected = True
self.lock.release() self.lock.release()
@ -155,7 +167,10 @@ class MikrotikAPI:
response = self._connection.path(path) response = self._connection.path(path)
_LOGGER.debug("API response (%s): %s", path, response) _LOGGER.debug("API response (%s): %s", path, response)
except librouteros.exceptions.ConnectionClosed: except librouteros.exceptions.ConnectionClosed:
_LOGGER.error("Mikrotik %s connection closed", self._host) if not self.connection_error_reported:
_LOGGER.error("Mikrotik %s connection closed", self._host)
self.connection_error_reported = True
self.disconnect() self.disconnect()
self.lock.release() self.lock.release()
return None return None
@ -169,12 +184,18 @@ class MikrotikAPI:
OSError, OSError,
ValueError, ValueError,
) as api_error: ) as api_error:
_LOGGER.error("Mikrotik %s error while path %s", self._host, api_error) if not self.connection_error_reported:
_LOGGER.error("Mikrotik %s error while path %s", self._host, api_error)
self.connection_error_reported = True
self.disconnect() self.disconnect()
self.lock.release() self.lock.release()
return None return None
except: except:
_LOGGER.error("Mikrotik %s error while path %s", self._host, "unknown") if not self.connection_error_reported:
_LOGGER.error("Mikrotik %s error while path %s", self._host, "unknown")
self.connection_error_reported = True
self.disconnect() self.disconnect()
self.lock.release() self.lock.release()
return None return None
@ -182,12 +203,18 @@ class MikrotikAPI:
try: try:
tuple(response) tuple(response)
except librouteros.exceptions.ConnectionClosed as api_error: except librouteros.exceptions.ConnectionClosed as api_error:
_LOGGER.error("Mikrotik %s error while path %s", self._host, api_error) if not self.connection_error_reported:
_LOGGER.error("Mikrotik %s error while path %s", self._host, api_error)
self.connection_error_reported = True
self.disconnect() self.disconnect()
self.lock.release() self.lock.release()
return None return None
except: except:
_LOGGER.error("Mikrotik %s error while path %s", self._host, "unknown") if not self.connection_error_reported:
_LOGGER.error("Mikrotik %s error while path %s", self._host, "unknown")
self.connection_error_reported = True
self.disconnect() self.disconnect()
self.lock.release() self.lock.release()
return None return None
@ -226,7 +253,10 @@ class MikrotikAPI:
try: try:
response.update(**params) response.update(**params)
except librouteros.exceptions.ConnectionClosed: except librouteros.exceptions.ConnectionClosed:
_LOGGER.error("Mikrotik %s connection closed", self._host) if not self.connection_error_reported:
_LOGGER.error("Mikrotik %s connection closed", self._host)
self.connection_error_reported = True
self.disconnect() self.disconnect()
self.lock.release() self.lock.release()
return False return False
@ -240,16 +270,22 @@ class MikrotikAPI:
OSError, OSError,
ValueError, ValueError,
) as api_error: ) as api_error:
_LOGGER.error( if not self.connection_error_reported:
"Mikrotik %s error while update %s", self._host, api_error _LOGGER.error(
) "Mikrotik %s error while update %s", self._host, api_error
)
self.connection_error_reported = True
self.disconnect() self.disconnect()
self.lock.release() self.lock.release()
return False return False
except: except:
_LOGGER.error( if not self.connection_error_reported:
"Mikrotik %s error while update %s", self._host, "unknown" _LOGGER.error(
) "Mikrotik %s error while update %s", self._host, "unknown"
)
self.connection_error_reported = True
self.disconnect() self.disconnect()
self.lock.release() self.lock.release()
return False return False
@ -291,7 +327,10 @@ class MikrotikAPI:
run = response("run", **{".id": tmp[".id"]}) run = response("run", **{".id": tmp[".id"]})
tuple(run) tuple(run)
except librouteros.exceptions.ConnectionClosed: except librouteros.exceptions.ConnectionClosed:
_LOGGER.error("Mikrotik %s connection closed", self._host) if not self.connection_error_reported:
_LOGGER.error("Mikrotik %s connection closed", self._host)
self.connection_error_reported = True
self.disconnect() self.disconnect()
self.lock.release() self.lock.release()
return False return False
@ -305,16 +344,22 @@ class MikrotikAPI:
OSError, OSError,
ValueError, ValueError,
) as api_error: ) as api_error:
_LOGGER.error( if not self.connection_error_reported:
"Mikrotik %s error while run_script %s", self._host, api_error _LOGGER.error(
) "Mikrotik %s error while run_script %s", self._host, api_error
)
self.connection_error_reported = True
self.disconnect() self.disconnect()
self.lock.release() self.lock.release()
return False return False
except: except:
_LOGGER.error( if not self.connection_error_reported:
"Mikrotik %s error while run_script %s", self._host, "unknown" _LOGGER.error(
) "Mikrotik %s error while run_script %s", self._host, "unknown"
)
self.connection_error_reported = True
self.disconnect() self.disconnect()
self.lock.release() self.lock.release()
return False return False
@ -351,7 +396,10 @@ class MikrotikAPI:
"API response (%s): %s", "/interface/monitor-traffic", traffic "API response (%s): %s", "/interface/monitor-traffic", traffic
) )
except librouteros.exceptions.ConnectionClosed: except librouteros.exceptions.ConnectionClosed:
_LOGGER.error("Mikrotik %s connection closed", self._host) if not self.connection_error_reported:
_LOGGER.error("Mikrotik %s connection closed", self._host)
self.connection_error_reported = True
self.disconnect() self.disconnect()
self.lock.release() self.lock.release()
return None return None
@ -365,16 +413,22 @@ class MikrotikAPI:
OSError, OSError,
ValueError, ValueError,
) as api_error: ) as api_error:
_LOGGER.error( if not self.connection_error_reported:
"Mikrotik %s error while get_traffic %s", self._host, api_error _LOGGER.error(
) "Mikrotik %s error while get_traffic %s", self._host, api_error
)
self.connection_error_reported = True
self.disconnect() self.disconnect()
self.lock.release() self.lock.release()
return None return None
except: except:
_LOGGER.error( if not self.connection_error_reported:
"Mikrotik %s error while get_traffic %s", self._host, "unknown" _LOGGER.error(
) "Mikrotik %s error while get_traffic %s", self._host, "unknown"
)
self.connection_error_reported = True
self.disconnect() self.disconnect()
self.lock.release() self.lock.release()
return None return None