From cc9206893b2e70cb5c73b410a6b387cfce8e02be Mon Sep 17 00:00:00 2001
From: Pothi Kalimuthu <1254302+pothi@users.noreply.github.com>
Date: Mon, 4 Sep 2023 19:01:38 +0530
Subject: [PATCH] Improve wifi enable / disable scripts; update docs

---
 ap-scripts/README.md        |  8 ++++++++
 ap-scripts/wifi-button.rsc  |  1 +
 ap-scripts/wifi-disable.rsc |  3 ++-
 ap-scripts/wifi-enable.rsc  | 10 +++++-----
 4 files changed, 16 insertions(+), 6 deletions(-)
 create mode 100644 ap-scripts/README.md

diff --git a/ap-scripts/README.md b/ap-scripts/README.md
new file mode 100644
index 0000000..e2d7c72
--- /dev/null
+++ b/ap-scripts/README.md
@@ -0,0 +1,8 @@
+# Scripts for Access Point
+
+Scripts for MikroTik devices with access point capability such as hAP series.
+
+Current Scripts...
+
+- Enable WiFi interfaces (early in the morning or whatever the preferred time).
+- Disable WiFi interfaces (at night, for example)
diff --git a/ap-scripts/wifi-button.rsc b/ap-scripts/wifi-button.rsc
index ad8b170..5985393 100644
--- a/ap-scripts/wifi-button.rsc
+++ b/ap-scripts/wifi-button.rsc
@@ -1,3 +1,4 @@
+# Only for Router OS v6
 # Ref: https://gist.github.com/sebastian13/47e788371474d73552593b621eeacd33
 
 :log info message=("mode button was pressed");
diff --git a/ap-scripts/wifi-disable.rsc b/ap-scripts/wifi-disable.rsc
index e69ea0c..f40fda0 100644
--- a/ap-scripts/wifi-disable.rsc
+++ b/ap-scripts/wifi-disable.rsc
@@ -6,6 +6,7 @@
 
 /system scheduler
 add comment="Shutdown WiFi @night to avoid electronic interference!" interval=1d name="WiFi Disable" on-event=\
-    "/int wifiwave2 disable [find]; /int wireless disable [find];" policy=ftp,reboot,read,write,policy,test start-date=mar/05/2022 start-time=00:04:00
+    ":do { /int wifiwave2 disable [find] } on-error={}; :do { /int wireless disable [find] } on-error={}"\
+    policy=ftp,reboot,read,write,policy,test start-date=sep/03/2023 start-time=23:04:00
 
 # /system routerboard mode-button set enabled=yes on-event=":log info \"Mode button pressed\"; /int wifiwave2 enable [find]; /int wireless enable [find];"
diff --git a/ap-scripts/wifi-enable.rsc b/ap-scripts/wifi-enable.rsc
index bfe62ae..ebd5436 100644
--- a/ap-scripts/wifi-enable.rsc
+++ b/ap-scripts/wifi-enable.rsc
@@ -15,21 +15,21 @@
 :local interfaces
 :local interface
 
-/interface 
 # :do { wifiwave2 enable [find]; } on-error={ :log info "Error enabling wifiwave2 interfaces" }
 :do {
-  :set interfaces [wireless print as-value]
+  :set interfaces [/int wifiwave2 print as-value]
 
 } on-error={
 
-  :log info "Wireless doesn't exist!";
+  :log info "Wifiwave2 doesn't exist!";
 
   :do {
-    :set interfaces [wifiwave2 print as-value]
-  } on-error={ :error "Wifiwave2 doesn't exist"; }
+    :set interfaces [/int wireless print as-value]
+  } on-error={ :error "Wireless doesn't exist"; }
 
 }
 
+/interface
 :foreach interface in=$interfaces do={
   :local wifiName ($interface->"name")
   :if ( [get $wifiName disabled] = true ) do={