From c4914960f289f1ca50ce3a1599e4bf6b9622897a Mon Sep 17 00:00:00 2001
From: Pothi Kalimuthu <1254302+pothi@users.noreply.github.com>
Date: Mon, 7 Aug 2023 09:53:05 +0530
Subject: [PATCH] Simplify the logic

---
 scripts/wifi-enable.rsc | 43 +++++++++++++++++++----------------------
 1 file changed, 20 insertions(+), 23 deletions(-)

diff --git a/scripts/wifi-enable.rsc b/scripts/wifi-enable.rsc
index 4b322e6..bfe62ae 100644
--- a/scripts/wifi-enable.rsc
+++ b/scripts/wifi-enable.rsc
@@ -1,12 +1,12 @@
 # Enable WiFi in the morning
 
 # using mode button
-/system routerboard mode-button set enabled=yes on-event=":log info \"Mode button pressed\"; /int wifiwave2 enable [find]; /int wireless enable [find];"
+# /system routerboard mode-button set enabled=yes on-event=":log info \"Mode button pressed\"; /int wifiwave2 enable [find]; /int wireless enable [find];"
 
 # as a cron event
-/system scheduler
-add comment="Enable WiFi @morning" interval=1d name="WiFi Enable" on-event="/int wifiwave2 enable [find]; /int wireless enable [find];" \
-    policy=read,write,policy,test start-date=jan/03/2022 start-time=05:30:00
+# /system scheduler
+# add comment="Enable WiFi @morning" interval=1d name="WiFi Enable" on-event="/int wifiwave2 enable [find]; /int wireless enable [find];" \
+    # policy=read,write,policy,test start-date=jan/03/2022 start-time=05:30:00
 
 # as a script to be used
 
@@ -15,28 +15,25 @@ add comment="Enable WiFi @morning" interval=1d name="WiFi Enable" on-event="/int
 :local interfaces
 :local interface
 
-# :do { /int wifiwave2 enable [find]; } on-error={ :log info "Error enabling wifiwave2 interfaces" }
+/interface 
+# :do { wifiwave2 enable [find]; } on-error={ :log info "Error enabling wifiwave2 interfaces" }
 :do {
+  :set interfaces [wireless print as-value]
 
-  /int wifiwave2
+} on-error={
 
-  :set interfaces [print as-value]
-  :foreach interface in=$interfaces do={
-    :local wifiName ($interface->"name")
-    :if ( [get $wifiName disabled] = true ) do={ enable $wifiName } else={ :log info "$wifiName is already running" }
-  }
-} on-error={ :log info "Wifiwave2 doesn't exist!" }
+  :log info "Wireless doesn't exist!";
 
+  :do {
+    :set interfaces [wifiwave2 print as-value]
+  } on-error={ :error "Wifiwave2 doesn't exist"; }
 
-# :do { /int wireless enable [find]; } on-error={ :log info "Error enabling wireless interfaces" }
-:do {
-
-  /int wireless
-
-  :set interfaces [print as-value]
-  :foreach interface in=$interfaces do={
-    :local wifiName ($interface->"name")
-    :if ( [get $wifiName disabled] = true ) do={ enable $wifiName } else={ :log info "$wifiName is already running" }
-  }
-} on-error={ :log info "Wireless interface doesn't exist. Probably using wifiwave!" }
+}
 
+:foreach interface in=$interfaces do={
+  :local wifiName ($interface->"name")
+  :if ( [get $wifiName disabled] = true ) do={
+    enable $wifiName
+    :log info "$wifiName is enabled";
+  } else={ :log info "$wifiName is already running" }
+}