dhcp-to-dns: rework, fix cleanup with mac-address and more

This commit is contained in:
Christian Hesse 2019-02-08 13:35:16 +01:00
parent a47aa45253
commit 7fc12f9e24

View file

@ -17,60 +17,52 @@
:set Zone ("dhcp." . $Domain); :set Zone ("dhcp." . $Domain);
} }
:local Ttl 5m; :local Ttl 5m;
:local HostName; :local CommentPrefix "managed by dhcp-to-dns for ";
:local Fqdn;
:local DnsIp;
:local DhcpIp;
:local DnsNode;
:local DhcpNode;
:foreach Static in=[ / ip dns static find where name ~ (".*\\." . $Zone) ] do={ :foreach Static in=[ / ip dns static find where comment ~ $CommentPrefix ] do={
:set Fqdn [ / ip dns static get $Static name ]; :local MacAddress [ $CharacterReplace [ / ip dns static get $Static comment ] $CommentPrefix "" ];
:set HostName [ :pick $Fqdn 0 ([ :len $Fqdn ] - ([ :len $Zone ] + 1)) ]; :local IpAddress [ / ip dns static get $Static address ];
:set DhcpNode [ / ip dhcp-server lease find where host-name=$HostName dynamic=yes ]; :local HostName [ / ip dns static get $Static name ];
:if ([ :len $DhcpNode ] > 0) do={ :if ([ / ip dhcp-server lease print count-only where mac-address=$MacAddress address=$IpAddress dynamic=yes ] > 0) do={
:log debug ("Lease for " . $HostName . " still exists. Not deleting."); :log debug ("Lease for " . $MacAddress . " (" . $HostName . ") still exists. Not deleting DNS entry.");
} else={ } else={
:local Found false; :local Found false;
:log info ("Lease expired for " . $HostName . ", deleting DNS entry."); :log info ("Lease expired for " . $MacAddress . " (" . $HostName . "), deleting DNS entry.");
/ ip dns static remove $Static; / ip dns static remove $Static;
} }
} }
:foreach Lease in=[ / ip dhcp-server lease find where dynamic=yes ] do={ :foreach Lease in=[ / ip dhcp-server lease find where dynamic=yes ] do={
:local Mac [ / ip dhcp-server lease get $Lease mac-address ]; :local Mac [ / ip dhcp-server lease get $Lease mac-address ];
:set DhcpIp [ / ip dhcp-server lease get $Lease address ]; :local DhcpIp [ / ip dhcp-server lease get $Lease address ];
:local Comment ("managed by dhcp-to-dns for " . $Mac); :local Comment ($CommentPrefix . $Mac);
:set HostName [ $CharacterReplace [ / ip dhcp-server lease get $Lease host-name ] " " "" ]; :local HostName [ $CharacterReplace [ / ip dhcp-server lease get $Lease host-name ] " " "" ];
:if ($HostName = "") do={ :if ($HostName = "") do={
:set HostName [ $CharacterReplace [ / ip dhcp-server lease get $Lease mac-address ] ":" "-" ]; :set HostName [ $CharacterReplace [ / ip dhcp-server lease get $Lease mac-address ] ":" "-" ];
} }
:if ([ :len $HostName ] > 0) do={ :local Fqdn ($HostName . "." . $Zone);
:set Fqdn ($HostName . "." . $Zone); :local DnsNode [ / ip dns static find where name=$Fqdn ];
:set DnsNode [ / ip dns static find where name=$Fqdn ]; :if ([ :len $DnsNode ] > 0) do={
:if ([ :len $DnsNode ] > 0) do={ :local DnsIp [ / ip dns static get $DnsNode address ];
:set DnsIp [ / ip dns static get $DnsNode address ]; :local Leases [ / ip dhcp-server lease find where host-name=$HostName dynamic=yes ];
:local HostNameCount [ / ip dhcp-server lease print count-only where host-name=$HostName dynamic=yes ];
:local Leases [ / ip dhcp-server lease find where host-name=$HostName dynamic=yes ]; :if ($HostNameCount > 1) do={
:local HostNameCount [ / ip dhcp-server lease print count-only where host-name=$HostName dynamic=yes ]; :foreach J,Lease in=$Leases do={
:if ($HostNameCount > 1) do={ :if ($J + 1 = $HostNameCount) do={
:foreach J,Lease in=$Leases do={ :set DhcpIp [ / ip dhcp-server lease get $Lease address ];
:if ($J + 1 = $HostNameCount) do={
:set DhcpIp [ / ip dhcp-server lease get $Lease address ];
}
} }
} }
:if ($DnsIp = $DhcpIp) do={
:log debug ("DNS entry for " . $Fqdn . " does not need updating.");
} else={
:log info ("Replacing DNS entry for " . $Fqdn . ", new address is " . $DhcpIp . ".");
/ ip dns static set name=$Fqdn address=$DhcpIp ttl=$Ttl comment=$Comment $DnsNode;
}
} else={
:log info ("Adding new DNS entry for " . $Fqdn . ", address is " . $DhcpIp . ".");
/ ip dns static add name=$Fqdn address=$DhcpIp ttl=$Ttl comment=$Comment;
} }
:if ($DnsIp = $DhcpIp) do={
:log debug ("DNS entry for " . $Fqdn . " does not need updating.");
} else={
:log info ("Replacing DNS entry for " . $Fqdn . ", new address is " . $DhcpIp . ".");
/ ip dns static set name=$Fqdn address=$DhcpIp ttl=$Ttl comment=$Comment $DnsNode;
}
} else={
:log info ("Adding new DNS entry for " . $Fqdn . ", address is " . $DhcpIp . ".");
/ ip dns static add name=$Fqdn address=$DhcpIp ttl=$Ttl comment=$Comment;
} }
} }