mirror.MikroTik/eworm.routeros-scripts
1
0
Fork 0
mirror of https://git.eworm.de/cgit/routeros-scripts synced 2025-07-15 20:44:31 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

collect-wireless-mac: rework, more use of arrays

Browse source
This commit is contained in:
Christian Hesse 2021-07-06 16:44:36 +02:00
parent 92a97b12ca
commit 5083ffd12f
3 changed files with 50 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

36
collect-wireless-mac.capsman
View file

@ -30,26 +30,25 @@ $ScriptLock $0 false 10;
} }
:local PlaceBefore ([ / caps-man access-list find where comment="--- collected above ---" disabled ]->0); :local PlaceBefore ([ / caps-man access-list find where comment="--- collected above ---" disabled ]->0);
:foreach RegTbl in=[ / caps-man registration-table find ] do={ :foreach Reg in=[ / caps-man registration-table find ] do={
:local Mac; :local RegVal;
:local AccessList;
:do { :do {
:set Mac [ / caps-man registration-table get $RegTbl mac-address ]; :set RegVal [ / caps-man registration-table get $Reg ];
:set AccessList ([ / caps-man access-list find where mac-address=$Mac ]->0);
} on-error={ } on-error={
$LogPrintExit2 debug $0 ("Device already gone... Ignoring.") false; $LogPrintExit2 debug $0 ("Device already gone... Ignoring.") false;
} }
:local AccessList ([ / caps-man access-list find where mac-address=($RegVal->"mac-address") ]->0);
:if ([ :len $AccessList ] > 0) do={ :if ([ :len $AccessList ] > 0) do={
$LogPrintExit2 debug $0 ("MAC address " . $Mac . " already known: " . \ $LogPrintExit2 debug $0 ("MAC address " . $RegVal->"mac-address" . " already known: " . \
[ / caps-man access-list get $AccessList comment ]) false; [ / caps-man access-list get $AccessList comment ]) false;
} }
:if ([ :typeof $Mac ] = "str" && [ :len $AccessList ] = 0) do={ :if ([ :typeof $RegVal ] = "array" && [ :len $AccessList ] = 0) do={
:local Address "no dhcp lease"; :local Address "no dhcp lease";
:local DnsName "no dhcp lease"; :local DnsName "no dhcp lease";
:local HostName "no dhcp lease"; :local HostName "no dhcp lease";
:local Lease ([ / ip dhcp-server lease find where mac-address=$Mac dynamic=yes status=bound ]->0); :local Lease ([ / ip dhcp-server lease find where mac-address=($RegVal->"mac-address") dynamic=yes status=bound ]->0);
:if ([ :len $Lease ] > 0) do={ :if ([ :len $Lease ] > 0) do={
:set Address [ / ip dhcp-server lease get $Lease address ]; :set Address [ / ip dhcp-server lease get $Lease address ];
:set HostName [ / ip dhcp-server lease get $Lease host-name ]; :set HostName [ / ip dhcp-server lease get $Lease host-name ];
@ -61,22 +60,19 @@ $ScriptLock $0 false 10;
:set DnsName "no dns name"; :set DnsName "no dns name";
} }
} }
:local RegEntry [ / caps-man registration-table find where mac-address=$Mac ];
:local Interface [ / caps-man registration-table get $RegEntry interface ];
:local Ssid [ / caps-man registration-table get $RegEntry ssid ];
:local DateTime ([ / system clock get date ] . " " . [ / system clock get time ]); :local DateTime ([ / system clock get date ] . " " . [ / system clock get time ]);
:local Vendor [ $GetMacVendor $Mac ]; :local Vendor [ $GetMacVendor ($RegVal->"mac-address") ];
:local Message ("unknown MAC address " . $Mac . " (" . $Vendor . ", " . $HostName . ") " . \ :local Message ("unknown MAC address " . $RegVal->"mac-address" . " (" . $Vendor . ", " . $HostName . ") " . \
"first seen on " . $DateTime . " connected to SSID " . $Ssid . ", interface " . $Interface); "first seen on " . $DateTime . " connected to SSID " . $RegVal->"ssid" . ", interface " . $RegVal->"interface");
$LogPrintExit2 info $0 $Message false; $LogPrintExit2 info $0 $Message false;
/ caps-man access-list add place-before=$PlaceBefore comment=$Message mac-address=$Mac disabled=yes; / caps-man access-list add place-before=$PlaceBefore comment=$Message mac-address=($RegVal->"mac-address") disabled=yes;
$SendNotification2 ({ origin=$0; \ $SendNotification2 ({ origin=$0; \
subject=([ $SymbolForNotification "mobile-phone" ] . $Mac . " connected to " . $Ssid); \ subject=([ $SymbolForNotification "mobile-phone" ] . $RegVal->"mac-address" . " connected to " . $RegVal->"ssid"); \
message=("A device with unknown MAC address connected to " . $Ssid . " on " . $Identity . ".\n\n" . \ message=("A device with unknown MAC address connected to " . $RegVal->"ssid" . " on " . $Identity . ".\n\n" . \
"Controller: " . $Identity . "\n" . \ "Controller: " . $Identity . "\n" . \
"Interface: " . $Interface . "\n" . \ "Interface: " . $RegVal->"interface" . "\n" . \
"SSID: " . $Ssid . "\n" . \ "SSID: " . $RegVal->"ssid" . "\n" . \
"MAC: " . $Mac . "\n" . \ "MAC: " . $RegVal->"mac-address" . "\n" . \
"Vendor: " . $Vendor . "\n" . \ "Vendor: " . $Vendor . "\n" . \
"Hostname: " . $HostName . "\n" . \ "Hostname: " . $HostName . "\n" . \
"Address: " . $Address . "\n" . \ "Address: " . $Address . "\n" . \

37
collect-wireless-mac.local
View file

@ -30,26 +30,25 @@ $ScriptLock $0 false 10;
} }
:local PlaceBefore ([ / interface wireless access-list find where comment="--- collected above ---" disabled ]->0); :local PlaceBefore ([ / interface wireless access-list find where comment="--- collected above ---" disabled ]->0);
:foreach RegTbl in=[ / interface wireless registration-table find ] do={ :foreach Reg in=[ / interface wireless registration-table find ] do={
:local Mac; :local RegVal;
:local AccessList;
:do { :do {
:set Mac [ / interface wireless registration-table get $RegTbl mac-address ]; :set RegVal [ / interface wireless registration-table get $Reg ];
:set AccessList ([ / interface wireless access-list find where mac-address=$Mac ]->0);
} on-error={ } on-error={
$LogPrintExit2 debug $0 ("Device already gone... Ignoring.") false; $LogPrintExit2 debug $0 ("Device already gone... Ignoring.") false;
} }
:local AccessList ([ / interface wireless access-list find where mac-address=($RegVal->"mac-address") ]->0);
:if ([ :len $AccessList ] > 0) do={ :if ([ :len $AccessList ] > 0) do={
$LogPrintExit2 debug $0 ("MAC address " . $Mac . " already known: " . \ $LogPrintExit2 debug $0 ("MAC address " . $RegVal->"mac-address" . " already known: " . \
[ / interface wireless access-list get $AccessList comment ]) false; [ / interface wireless access-list get $AccessList comment ]) false;
} }
:if ([ :typeof $Mac ] = "str" && [ :len $AccessList ] = 0) do={ :if ([ :typeof $RegVal ] = "array" && [ :len $AccessList ] = 0) do={
:local Address "no dhcp lease"; :local Address "no dhcp lease";
:local DnsName "no dhcp lease"; :local DnsName "no dhcp lease";
:local HostName "no dhcp lease"; :local HostName "no dhcp lease";
:local Lease ([ / ip dhcp-server lease find where mac-address=$Mac dynamic=yes status=bound ]->0); :local Lease ([ / ip dhcp-server lease find where mac-address=($RegVal->"mac-address") dynamic=yes status=bound ]->0);
:if ([ :len $Lease ] > 0) do={ :if ([ :len $Lease ] > 0) do={
:set Address [ / ip dhcp-server lease get $Lease address ]; :set Address [ / ip dhcp-server lease get $Lease address ];
:set HostName [ / ip dhcp-server lease get $Lease host-name ]; :set HostName [ / ip dhcp-server lease get $Lease host-name ];
@ -61,22 +60,20 @@ $ScriptLock $0 false 10;
:set DnsName "no dns name"; :set DnsName "no dns name";
} }
} }
:local RegEntry [ / interface wireless registration-table find where mac-address=$Mac ]; :set ($RegVal->"ssid") [ / interface wireless get [ find where name=($RegVal->"interface") ] ssid ];
:local Interface [ / interface wireless registration-table get $RegEntry interface ];
:local Ssid [ / interface wireless get [ find where name=$Interface ] ssid ];
:local DateTime ([ / system clock get date ] . " " . [ / system clock get time ]); :local DateTime ([ / system clock get date ] . " " . [ / system clock get time ]);
:local Vendor [ $GetMacVendor $Mac ]; :local Vendor [ $GetMacVendor ($RegVal->"mac-address") ];
:local Message ("unknown MAC address " . $Mac . " (" . $Vendor . ", " . $HostName . ") " . \ :local Message ("unknown MAC address " . $RegVal->"mac-address" . " (" . $Vendor . ", " . $HostName . ") " . \
"first seen on " . $DateTime . " connected to SSID " . $Ssid . ", interface " . $Interface); "first seen on " . $DateTime . " connected to SSID " . $RegVal->"ssid" . ", interface " . $RegVal->"interface");
$LogPrintExit2 info $0 $Message false; $LogPrintExit2 info $0 $Message false;
/ interface wireless access-list add place-before=$PlaceBefore comment=$Message mac-address=$Mac disabled=yes; / interface wireless access-list add place-before=$PlaceBefore comment=$Message mac-address=($RegVal->"mac-address") disabled=yes;
$SendNotification2 ({ origin=$0; \ $SendNotification2 ({ origin=$0; \
subject=([ $SymbolForNotification "mobile-phone" ] . $Mac . " connected to " . $Ssid); \ subject=([ $SymbolForNotification "mobile-phone" ] . $RegVal->"mac-address" . " connected to " . $RegVal->"ssid"); \
message=("A device with unknown MAC address connected to " . $Ssid . " on " . $Identity . ".\n\n" . \ message=("A device with unknown MAC address connected to " . $RegVal->"ssid" . " on " . $Identity . ".\n\n" . \
"Controller: " . $Identity . "\n" . \ "Controller: " . $Identity . "\n" . \
"Interface: " . $Interface . "\n" . \ "Interface: " . $RegVal->"interface" . "\n" . \
"SSID: " . $Ssid . "\n" . \ "SSID: " . $RegVal->"ssid" . "\n" . \
"MAC: " . $Mac . "\n" . \ "MAC: " . $RegVal->"mac-address" . "\n" . \
"Vendor: " . $Vendor . "\n" . \ "Vendor: " . $Vendor . "\n" . \
"Hostname: " . $HostName . "\n" . \ "Hostname: " . $HostName . "\n" . \
"Address: " . $Address . "\n" . \ "Address: " . $Address . "\n" . \

38
collect-wireless-mac.template
View file

@ -31,26 +31,25 @@ $ScriptLock $0 false 10;
} }
:local PlaceBefore ([ / %PATH% access-list find where comment="--- collected above ---" disabled ]->0); :local PlaceBefore ([ / %PATH% access-list find where comment="--- collected above ---" disabled ]->0);
:foreach RegTbl in=[ / %PATH% registration-table find ] do={ :foreach Reg in=[ / %PATH% registration-table find ] do={
:local Mac; :local RegVal;
:local AccessList;
:do { :do {
:set Mac [ / %PATH% registration-table get $RegTbl mac-address ]; :set RegVal [ / %PATH% registration-table get $Reg ];
:set AccessList ([ / %PATH% access-list find where mac-address=$Mac ]->0);
} on-error={ } on-error={
$LogPrintExit2 debug $0 ("Device already gone... Ignoring.") false; $LogPrintExit2 debug $0 ("Device already gone... Ignoring.") false;
} }
:local AccessList ([ / %PATH% access-list find where mac-address=($RegVal->"mac-address") ]->0);
:if ([ :len $AccessList ] > 0) do={ :if ([ :len $AccessList ] > 0) do={
$LogPrintExit2 debug $0 ("MAC address " . $Mac . " already known: " . \ $LogPrintExit2 debug $0 ("MAC address " . $RegVal->"mac-address" . " already known: " . \
[ / %PATH% access-list get $AccessList comment ]) false; [ / %PATH% access-list get $AccessList comment ]) false;
} }
:if ([ :typeof $Mac ] = "str" && [ :len $AccessList ] = 0) do={ :if ([ :typeof $RegVal ] = "array" && [ :len $AccessList ] = 0) do={
:local Address "no dhcp lease"; :local Address "no dhcp lease";
:local DnsName "no dhcp lease"; :local DnsName "no dhcp lease";
:local HostName "no dhcp lease"; :local HostName "no dhcp lease";
:local Lease ([ / ip dhcp-server lease find where mac-address=$Mac dynamic=yes status=bound ]->0); :local Lease ([ / ip dhcp-server lease find where mac-address=($RegVal->"mac-address") dynamic=yes status=bound ]->0);
:if ([ :len $Lease ] > 0) do={ :if ([ :len $Lease ] > 0) do={
:set Address [ / ip dhcp-server lease get $Lease address ]; :set Address [ / ip dhcp-server lease get $Lease address ];
:set HostName [ / ip dhcp-server lease get $Lease host-name ]; :set HostName [ / ip dhcp-server lease get $Lease host-name ];
@ -62,23 +61,20 @@ $ScriptLock $0 false 10;
:set DnsName "no dns name"; :set DnsName "no dns name";
} }
} }
:local RegEntry [ / %PATH% registration-table find where mac-address=$Mac ]; :set ($RegVal->"ssid") [ / interface wireless get [ find where name=($RegVal->"interface") ] ssid ];
:local Interface [ / %PATH% registration-table get $RegEntry interface ];
:local Ssid [ / caps-man registration-table get $RegEntry ssid ];
:local Ssid [ / interface wireless get [ find where name=$Interface ] ssid ];
:local DateTime ([ / system clock get date ] . " " . [ / system clock get time ]); :local DateTime ([ / system clock get date ] . " " . [ / system clock get time ]);
:local Vendor [ $GetMacVendor $Mac ]; :local Vendor [ $GetMacVendor ($RegVal->"mac-address") ];
:local Message ("unknown MAC address " . $Mac . " (" . $Vendor . ", " . $HostName . ") " . \ :local Message ("unknown MAC address " . $RegVal->"mac-address" . " (" . $Vendor . ", " . $HostName . ") " . \
"first seen on " . $DateTime . " connected to SSID " . $Ssid . ", interface " . $Interface); "first seen on " . $DateTime . " connected to SSID " . $RegVal->"ssid" . ", interface " . $RegVal->"interface");
$LogPrintExit2 info $0 $Message false; $LogPrintExit2 info $0 $Message false;
/ %PATH% access-list add place-before=$PlaceBefore comment=$Message mac-address=$Mac disabled=yes; / %PATH% access-list add place-before=$PlaceBefore comment=$Message mac-address=($RegVal->"mac-address") disabled=yes;
$SendNotification2 ({ origin=$0; \ $SendNotification2 ({ origin=$0; \
subject=([ $SymbolForNotification "mobile-phone" ] . $Mac . " connected to " . $Ssid); \ subject=([ $SymbolForNotification "mobile-phone" ] . $RegVal->"mac-address" . " connected to " . $RegVal->"ssid"); \
message=("A device with unknown MAC address connected to " . $Ssid . " on " . $Identity . ".\n\n" . \ message=("A device with unknown MAC address connected to " . $RegVal->"ssid" . " on " . $Identity . ".\n\n" . \
"Controller: " . $Identity . "\n" . \ "Controller: " . $Identity . "\n" . \
"Interface: " . $Interface . "\n" . \ "Interface: " . $RegVal->"interface" . "\n" . \
"SSID: " . $Ssid . "\n" . \ "SSID: " . $RegVal->"ssid" . "\n" . \
"MAC: " . $Mac . "\n" . \ "MAC: " . $RegVal->"mac-address" . "\n" . \
"Vendor: " . $Vendor . "\n" . \ "Vendor: " . $Vendor . "\n" . \
"Hostname: " . $HostName . "\n" . \ "Hostname: " . $HostName . "\n" . \
"Address: " . $Address . "\n" . \ "Address: " . $Address . "\n" . \