mirror.MikroTik/eworm-de.routeros-scripts_main
1
0
Fork 0
mirror of https://github.com/eworm-de/routeros-scripts.git synced 2025-08-04 10:14:56 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

global: variable names are CamelCase

Browse source 
___  _         ___     __
           / _ )(_)__ _   / _/__ _/ /_
          / _  / / _ `/  / _/ _ `/ __/
         /____/_/\_, /  /_/ \_,_/\__/
 _       __     /___/       _             __
| |     / /___ __________  (_)___  ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / /  / / / / / / / / /_/ /_/
|__/|__/\__,_/_/  /_/ /_/_/_/ /_/\__, (_)
                                /____/

RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:

[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

That looks ok. Now we use a script:

{ :local interface "en1";
  / interface print where name=$interface; }

And the result...

[admin@MikroTik] > { :local interface "en1";
{...   / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

... still looks ok.
We make a little modification to the script:

{ :local name "en1";
  / interface print where name=$name; }

And the result:

[admin@MikroTik] > { :local name "en1";
{...   / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
 1   S en2                                 ether            1500  1598
 2   S en3                                 ether            1500  1598
 3   S en4                                 ether            1500  1598
 4   S en5                                 ether            1500  1598
 5  R  br-local                            bridge           1500  1598

Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).

And another modification:

{ :local type "en1";
  / interface print where name=$type; }

And the result:

[admin@MikroTik] > { :local type "en1";
{...   / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU

Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.

The answer from MikroTik support (in Ticket#2019010222000454):

> This is how scripting works in RouterOS and we will not fix it.

To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...

*fingers crossed*
This commit is contained in:
Christian Hesse 2019-01-03 17:45:43 +01:00
parent 7d06a7e8c2
commit 870f00bb36
41 changed files with 770 additions and 777 deletions
Download patch file Download diff file Expand all files Collapse all files

56
check-routeros-update
View file

@ -4,9 +4,9 @@
#
# check for RouterOS update, send notification e-mails
:global "identity";
:global "safe-update-url";
:global "sent-routeros-update-notification";
:global Identity;
:global SafeUpdateUrl;
:global SentRouterosUpdateNotification;
:global SendNotification;
@ -18,45 +18,45 @@
}
/ system package update check-for-updates without-paging;
:local installedversion [ / system package update get installed-version ];
:local latestversion [ / system package update get latest-version ];
:local InstalledVersion [ / system package update get installed-version ];
:local LatestVersion [ / system package update get latest-version ];
:if ($installedversion != $latestversion) do={
:local channel [ / system package update get channel ];
:local model [ / system routerboard get model ];
:local serialnumber [ / system routerboard get serial-number ];
:if ($InstalledVersion != $LatestVersion) do={
:local Channel [ / system package update get channel ];
:local Model [ / system routerboard get model ];
:local SerialNumber [ / system routerboard get serial-number ];
:if ([ :len $"safe-update-url" ] > 0) do={
:local result;
:if ([ :len $SafeUpdateUrl ] > 0) do={
:local Result;
:do {
:set result [ / tool fetch check-certificate=yes-without-crl \
($"safe-update-url" . $channel . "?installed=" . $installedversion . \
"&latest=" . $latestversion) output=user as-value ];
:set Result [ / tool fetch check-certificate=yes-without-crl \
($SafeUpdateUrl . $Channel . "?installed=" . $InstalledVersion . \
"&latest=" . $LatestVersion) output=user as-value ];
} on-error={
:log warning ("Failed receiving safe version for " . $channel . ".");
:log warning ("Failed receiving safe version for " . $Channel . ".");
}
:if ($result->"status" = "finished" && $result->"data" = $latestversion) do={
:log info ("Version " . $latestversion . " is assumed safe, updating...");
:if ($Result->"status" = "finished" && $Result->"data" = $LatestVersion) do={
:log info ("Version " . $LatestVersion . " is considered safe, updating...");
$SendNotification ("RouterOS update notification") \
("Version " . $latestversion . " is assumed safe for " . $channel . \
", updating on " . $identity . "...");
("Version " . $LatestVersion . " is considered safe for " . $Channel . \
", updating on " . $Identity . "...");
/ system package update install;
:error "Waiting for system to reboot.";
}
}
:if ($"sent-routeros-update-notification" = $latestversion) do={
:if ($SentRouterosUpdateNotification = $LatestVersion) do={
:error ("Already sent the RouterOS update notification for version " . \
$latestversion . ".");
$LatestVersion . ".");
}
$SendNotification ("RouterOS update notification") \
("There is a RouterOS update available\n\n" . \
"Routerboard: " . $model . "\n" . \
"Serial number: " . $serialnumber . "\n" . \
"Hostname: " . $identity . "\n" . \
"Channel: " . $channel . "\n" . \
"Installed: " . $installedversion . "\n" . \
"Available: " . $latestversion);
:set "sent-routeros-update-notification" $latestversion;
"Routerboard: " . $Model . "\n" . \
"Serial number: " . $SerialNumber . "\n" . \
"Hostname: " . $Identity . "\n" . \
"Channel: " . $Channel . "\n" . \
"Installed: " . $InstalledVersion . "\n" . \
"Available: " . $LatestVersion);
:set SentRouterosUpdateNotification $LatestVersion;
}