From 217e271cd49649357c18ca3803107698a9245f6e Mon Sep 17 00:00:00 2001
From: Eduardo Silva <eduardo@eth0.com.br>
Date: Wed, 5 Feb 2025 16:49:59 -0300
Subject: [PATCH] Improved multiple backup js

---
 router_manager/views.py                   |   5 +-
 routerfleet/settings.py                   |   2 +-
 templates/router_manager/router_list.html | 141 +++++++++++++---------
 3 files changed, 84 insertions(+), 64 deletions(-)

diff --git a/router_manager/views.py b/router_manager/views.py
index 5b3355f..178f31e 100644
--- a/router_manager/views.py
+++ b/router_manager/views.py
@@ -258,10 +258,7 @@ def view_create_instant_backup_multiple_routers(request):
         for uuid in uuids:
             router = get_object_or_404(Router, uuid=uuid)
             error = create_instant_backup(router)
-            if error:
-                results.append({'router': router.name, 'status': error})
-            else:
-                results.append({'router': router.name, 'status': 'backup started'})
+            results.append({'router': router.name, 'status': error})
 
         return JsonResponse({'results': results})
 
diff --git a/routerfleet/settings.py b/routerfleet/settings.py
index a4c94ae..9b19562 100644
--- a/routerfleet/settings.py
+++ b/routerfleet/settings.py
@@ -142,6 +142,6 @@ STATICFILES_DIRS = [
 
 DEFAULT_AUTO_FIELD = 'django.db.models.BigAutoField'
 MEDIA_ROOT = '/var/lib/routerfleet/'
-ROUTERFLEET_VERSION = 7023
+ROUTERFLEET_VERSION = 7501
 
 from routerfleet.production_settings import *
diff --git a/templates/router_manager/router_list.html b/templates/router_manager/router_list.html
index 849d941..de89fbb 100644
--- a/templates/router_manager/router_list.html
+++ b/templates/router_manager/router_list.html
@@ -74,17 +74,14 @@
                                 {% endfor %}
                                 </tbody>
                             </table>
-
                         </div>
                         <div class="row mb-3">
                         <div class="col-lg-12 text-right">
-                            <div class="btn-group" role="group">
-                                <a href="/router/manage/" class="btn btn-primary">Add Router</a>
-                                <a href="/router/import_tool/" class="btn btn-warning">Import Tool</a>
-                                <button id="select-all" class="btn btn-outline-success"><i class="fas fa-check-square"></i> Select All</button>
-                                <button id="select-none" class="btn btn-outline-danger"><i class="fas fa-square"></i> Select None</button>
-                                <button id="create-backup" class="btn btn-warning" style="display: none;">Create Backup Task</button>
-                            </div>
+                            <a href="/router/manage/" class="btn btn-primary">Add Router</a>
+                            <a href="/router/import_tool/" class="btn btn-primary">Import Tool</a>
+                            <button id="select-all" class="btn btn-outline-primary" title="Select All"><i class="fas fa-check-square"></i></button>
+                            <button id="select-none" class="btn btn-outline-primary" title="Select None"><i class="fas fa-square"></i></button>
+                            <button id="create-backup" class="btn btn-warning" style="display: none;">Create Backup Task</button>
                         </div>
                     </div>
                     </div>
@@ -159,58 +156,84 @@
             checkStatusChange();
         });
     </script>
-<script>
-    $(document).ready(function() {
-        $('.router-checkbox').prop('checked', false);
-    
-        $('#select-all').click(function() {
-            $('.router-checkbox').prop('checked', true).trigger('change');
-        });
-    
-        $('#select-none').click(function() {
-            $('.router-checkbox').prop('checked', false).trigger('change');
-        });
-    
-        $('.router-checkbox').change(function() {
-            var checkedCount = $('.router-checkbox:checked').length;
-            $('#create-backup').toggle(checkedCount >= 1);
-        });
-    
-        $('#create-backup').click(function() {
-            var selectedRouters = $('.router-checkbox:checked').map(function() {
-                return $(this).data('uuid');
-            }).get();
-    
-            $.ajax({
-                url: '/router/create_instant_backup/multiple/',
-                method: 'POST',
-                data: {
-                    routers: selectedRouters,
-                    csrfmiddlewaretoken: '{{ csrf_token }}'
-                },
-                success: function(response) {
-                    let messages = response.results.map(item => `${item.router}: ${item.status}`).join('\n');
-                    // Create success toast
-                    $(document).Toasts('create', {
-                        class: 'bg-success',
-                        title: 'Backup Status',
-                        body: 'The following routers were backed up: ' + messages,
-                        delay: 10000,
-                        autohide: true
-                    });
-                },
-                error: function(xhr) {
-                    // Create error toast
-                    $(document).Toasts('create', {
-                        class: 'bg-danger',
-                        title: 'Error',
-                        body: 'Error: ' + xhr.responseJSON.error,
-                        delay: 10000,
-                        autohide: true
-                    });
-                }
+
+    <script>
+        $(document).ready(function() {
+            $('.router-checkbox').prop('checked', false);
+
+            $('#select-all').click(function() {
+                $('.router-checkbox').prop('checked', true).trigger('change');
+            });
+
+            $('#select-none').click(function() {
+                $('.router-checkbox').prop('checked', false).trigger('change');
+            });
+
+            $('.router-checkbox').change(function() {
+                var checkedCount = $('.router-checkbox:checked').length;
+                $('#create-backup').toggle(checkedCount >= 1);
+            });
+
+            $('#create-backup').click(function() {
+                var selectedRouters = $('.router-checkbox:checked').map(function() {
+                    return $(this).data('uuid');
+                }).get();
+
+                $.ajax({
+                    url: '/router/create_instant_backup/multiple/',
+                    method: 'POST',
+                    data: {
+                        routers: selectedRouters,
+                        csrfmiddlewaretoken: '{{ csrf_token }}'
+                    },
+                    success: function(response) {
+                        let successRouters = [];
+                        let errorMessages = [];
+
+                        response.results.forEach(function(item) {
+                            if (item.status === null || item.status === undefined || item.status === '') {
+                                successRouters.push(item.router);
+                            } else {
+                                errorMessages.push(item.router + ': ' + item.status);
+                            }
+                        });
+
+                        if (successRouters.length > 0) {
+                            $(document).Toasts('create', {
+                                class: 'bg-success',
+                                title: 'Backup Started',
+                                body: 'Backup started for:<br>' + successRouters.join('<br>'),
+                                delay: 10000,
+                                autohide: true
+                            });
+                        }
+
+                        if (errorMessages.length > 0) {
+                            $(document).Toasts('create', {
+                                class: 'bg-danger',
+                                title: 'Backup Errors',
+                                body: 'Problems:<br>' + errorMessages.join('<br>'),
+                                delay: 10000,
+                                autohide: true
+                            });
+                        }
+
+                        $('.router-checkbox').prop('checked', false).trigger('change');
+                    },
+                    error: function(xhr) {
+                        $(document).Toasts('create', {
+                            class: 'bg-danger',
+                            title: 'Error',
+                            body: 'Error: ' + xhr.responseJSON.error,
+                            delay: 10000,
+                            autohide: true
+                        });
+                        $('.router-checkbox').prop('checked', false).trigger('change');
+                    }
+                });
             });
         });
-    });
     </script>
+
+
 {% endblock %}
\ No newline at end of file