mirror.MikroTik/beeyev.Mikrotik-RouterOS-automatic-backup-and-update
1
0
Fork 0
mirror of https://github.com/beeyev/Mikrotik-RouterOS-automatic-backup-and-update.git synced 2025-07-15 16:34:34 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor date and time handling in backup script for improved format compatibility

Browse source
This commit is contained in:
Alexander Tebiev 2025-04-02 12:03:16 +02:00
parent 130b80e5d7
commit 96352e4f38
1 changed files with 17 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

42
v2.rsc
View file

@ -66,31 +66,23 @@
:log info "\n$SMP script \"Mikrotik RouterOS automatic backup & update\" started."; :log info "\n$SMP script \"Mikrotik RouterOS automatic backup & update\" started.";
:log info "$SMP Script Mode: $scriptMode, forceBackup: $forceBackup"; :log info "$SMP Script Mode: $scriptMode, forceBackup: $forceBackup";
:local scriptVersion "24.06.04";
# Check email settings # Current time `hh-mm-ss`
:if ([:len $emailAddress] = 0) do={ :local currentTime ([:pick [/system clock get time] 0 2] . "-" . [:pick [/system clock get time] 3 5] . "-" . [:pick [/system clock get time] 6 8]);
:log error ("$SMP \$emailAddress variable is empty. Script stopped.");
:error "$SMP bye!";
}
:local emailServer ""
:do {
:set emailServer [/tool e-mail get server];
} on-error={
# Old of getting email server before the RouterOS v7.12
:log info "$SMP Checking email server using old command `/tool e-mail get address`";
:set emailServer [/tool e-mail get address];
}
:if ($emailServer = "0.0.0.0" or [:len $emailServer] = 0) do={
:log error ("$SMP Email server address is not configured or is invalid. Please configure it in Tools -> Email and try again. Script stopped.");
:error "$SMP bye!";
}
:if ([:len [/tool e-mail get from]] = 0 or [/tool e-mail get from] = "<>" or [:find [/tool e-mail get from] "@"] = -1) do={
:log error ("$SMP Email configuration FROM address is missing or invalid. Please configure it in Tools -> Email and try again. Script stopped.");
:error "$SMP bye!";
}
# Current date `YYYY-MM-DD`, will be defined later in the script
:local currentDate "undefined";
#Check if proper identity name is set # Checking if the date is in the old format with slashes and month name (e.g., `nov/11/2023`)
if ([:len [/system identity get name]] = 0 or [/system identity get name] = "MikroTik") do={ :if ([:len [:tonum [:pick [/system clock get date] 0 1]]] = 0) do={
:log warning ("$SMP Please set identity name of your device (System -> Identity), keep it short and informative."); # Convert the old date format
}; # Example: `nov/11/2023` to `2023-nov-11`
:set currentDate ([:pick [/system clock get date] 7 11] . "-" . [:pick [/system clock get date] 0 3] . "-" . [:pick [/system clock get date] 4 6]);
} else={
# getting current date in the new format (e.g., `2023-11-11`)
:set currentDate [/system clock get date];
};
# current date and time in the format `YYYY-MM-DD-hh-mm-ss` or `YYYY-Mon-11-hh-mm-ss`
:local currentDateTime ($currentDate . "-" . $currentTime);