* Move splitting code to own file.
* Move list to dictionary code to quoting as well.
* Add quoting functionality.
* Add quoting filters.
* Add integration tests to CI.
* Fix bugs, increase coverage.
* Make parsing more strict.
* Extract function parse_argument_value from split_routeros_command to make proper parsing of WHERE possible.
* Adjust expected error message in integration tests.
* Simplify code and improve coverage.
* Add changelog fragment for WHERE strictness in api module.
* Add documenation.
* Fix typo.
* Add documentation references.
* Add example to api module which uses quote_argument_value.
* Fix bug, and add tests which prevent this in the future.
* Add more escape sequence tests.
* Make sure all control characters are quoted.
* fix(api): fixed a bug when splitting the argument string
* fix(api): added the shlex module for splitting
* fix(api): added the shlex module for splitting
* fix(api): moved shlex.split to self method split_params
* Fix indentation.
* Implement custom splitting algorithm.
* Raise AssertionError in case of internal error.
* Update plugins/modules/api.py
this is correct thanks !
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Nikolay Dachev <nikolay@dachev.info>
* Allow api module to fail.
* Improve error handling.
* Fix api unit tests.
* Add very basic tests of return values.
* Update api.py
fix ignoring the Fail task if we get TrapError
* Do not mangle fail result, and adjust tests.
* Improve changelog fragment.
* Reclassify changelog fragment as minor_changes, improve text.
* Mark changelog as 'breaking change'.
Co-authored-by: Nikolay Dachev <nikolay@dachev.info>
* allow nonverbose idempotent config
* nonverbose config output
* typpo
* typpo
* release fragment
* config extra fact
* add fact ansible_net_config_nonverbose
* unit tests
* changelog fragments
* remove version fragment
* remove extra debug printf()
* update chlog fragment
* corrections for upstream pull request
* corrections for upstream pull request
* typo in changelog fragment
Co-authored-by: Felix Fontein <felix@fontein.de>
* typo in filename
Co-authored-by: Petr Klima <petr.klima@madeta.cz>
Co-authored-by: Felix Fontein <felix@fontein.de>
* Set export on Config to verbose
SUMMARY
In the configuration export session i think that using /export verbose is better than just /export, because with export only some configurations sections are going to be missed like BGP configuration, as proposed in https://github.com/ansible/ansible/pull/67868
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
facts.py
ADDITIONAL INFORMATION
extract of the output with /export verbose
# software id =
#
#
#
/interface ethernet
set [ find default-name=ether1 ] advertise=\
10M-half,10M-full,100M-half,100M-full,1000M-full arp=enabled arp-timeout=\
auto auto-negotiation=yes cable-settings=default disable-running-check=\
yes disabled=no full-duplex=yes loop-protect=default \
loop-protect-disable-time=5m loop-protect-send-interval=5s mac-address=\
50:00:00:02:00:00 mtu=1500 name=ether1 orig-mac-address=50:00:00:02:00:00 \
rx-flow-control=off speed=1Gbps tx-flow-control=off
set [ find default-name=ether2 ] advertise=\
10M-half,10M-full,100M-half,100M-full,1000M-full arp=enabled arp-timeout=\
auto auto-negotiation=yes cable-settings=default disable-running-check=\
yes disabled=no full-duplex=yes loop-protect=default \
loop-protect-disable-time=5m loop-protect-send-interval=5s mac-address=\
50:00:00:02:00:01 mtu=1500 name=ether2 orig-mac-address=50:00:00:02:00:01 \
rx-flow-control=off speed=1Gbps tx-flow-control=off
set [ find default-name=ether3 ] advertise=\
.....
.....
Extract of Output with only /export:
# software id =
#
#
#
/interface wireless security-profiles
set [ find default=yes ] supplicant-identity=MikroTik
/ip dhcp-client
add dhcp-options=hostname,clientid disabled=no interface=ether1
<END>
* Create 104_facts_export_verbose
* Update changelogs/fragments/104_facts_export_verbose
Co-authored-by: Felix Fontein <felix@fontein.de>
* Rename export to export_verbose
* Rename 104_facts_export_verbose to 104_facts_export_verbose.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* add api.py
* fix yaml
* query doc fix
* query doc fix
* fix exmaples
* dummy force retest
* fix small typo in RETURN
* remove no_log which conflict with routeros add param.
* fix pep8
* fix no_log conflict base on issue: password/pass no_log #49465
* ver 1.0.1
* small docs change
* more docs fix
* last one for docs change
* pip8 fix
* Update plugins/modules/api.py
I did not nice that .. Thank you!
Co-authored-by: Felix Fontein <felix@fontein.de>
* remove metadata block
* do not allow empty values to be added in execution path
* Update plugins/modules/api.py
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
* fixes for the last review
* Apply suggestions from code review
more fixes
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
* small changes in examples 'a' vs 'A'
* Apply suggestions from code review
more docs string fixes
Co-authored-by: Felix Fontein <felix@fontein.de>
* fixses in docs, reomve no_logs
* fix example vars
* fix again example a/A
* missing C in C()
* add external conn func
* fix pep8
* fix pep8 test2
* fix pep8 test3
* fix HAS_LIB
* return Ex as e
* fix pep8
* api unit test
* change unit test, change module structure
* pep8 fix
* more pep8
* some progress with unit test
* mm fix
* mock libros fix
* test
* try to fix mock
* test
* test mock
* more unit test
* libtoueros py3 only
* pytest importskyp added
* more unit test
* add update func unit test
* +more unit, fix mutually_exclusive
* fix missed , for module arg
* Apply suggestions from code review
typos fixes
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
* Update plugins/modules/api.py
will fix others as well
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
* fix docs
* small doc fix
* fix missing dots etc. in doc
* unit test completed
* reduce dummy Key func
* fix Key return
* final fix
* fix pep8
* fix pep8
Co-authored-by: root <root@syslin.sof.dachev.lan>
Co-authored-by: Nikolay Dachev <dako@Uranus.sof.dachev.lan>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
* facts: Allow multiple entries per iface
There can be multiple addresses per interface, as well as multiple
neighbors.
This changes the format of "ansible_net_neighbors" to list instead of
dict, because the old format could not store multiple neighbors per
interface.
Also, this fixes a crash when the ipv6 module is not loaded, because the
error "bad command name" was being parsed with interface=None
* facts: Fix tests
* facts: Add changelog fragment
