* Fixes#236: Add missing parameters
The parameters "address-list", "address-list-timeout", and "realm" were
missing for some subpaths of "ip firewall" and are now added.
Additionally the default value of "False" for the "disabled" parameter
has been set so that an e.g. firewall rule, which was disabled
(disabled=True) is enabled (disabled=False) after removing the
"disabled" argument in the data.
Some more parameters can now be removed, e.g. "jump-target", "log", and "log-prefix",
which are not mandatory.
* Add missing changes for #236
Additionally fixed the PR id in the changelog fragment.
* Update changelogs/fragments/237-add-missing-ip-firewall-attributes.yml
Full stop added at the end of the changelog fragment
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update changelogs/fragments/237-add-missing-ip-firewall-attributes.yml
Full stop added at the end of the changelog fragment
Co-authored-by: Felix Fontein <felix@fontein.de>
* Fix unit tests
---------
Co-authored-by: Johannes Münch <git@washiza.eu>
Co-authored-by: Felix Fontein <felix@fontein.de>
- doh-max-concurrent-queries
- doh-max-server-connections
- doh-timeout
The parameters mentioned above seem to be added in version 7.8 as far as
I could tell from the changelogs.
Co-authored-by: Johannes Münch <git@washiza.eu>
* Fix some bugs and adapt RouterOS v.7.12 changes
/ip traffic-flow target: make it a multiple value (single_value=False)
field
/routing id: add comment attribute
/tool e-mail: add versioning to the parameters as "address" was renamed to "server" in 7.12
/routing bgp connection: add missing attributes
* Add changelog fragment
* Fix duplicate key 'output.network'
* Split up the changelog fragment
---------
Co-authored-by: Johannes Münch <git@washiza.eu>
Commit e4a21311 added API data for the "interface wireless" path. It
contained the read-only "running" parameter. Writing to the parameter
fails:
Error while modifying for name="…" (ID *3): unknown parameter running
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
A few defaults were missing for `ppp profile`. Mark the path as fully
understood to enable its use in Ansible tasks.
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
A few fields were missing for `interface wireless security-profiles`
(e.g. `disabled`). `default` on the other hand is a built-in property
which can't be modified.
Mark the `interface wireless security-profiles` path as fully understood
to enable its use in Ansible tasks.
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Commit 2164261 added support for `interface ppp-client`. It missed the
`apn` property and added the runtime-only `running` property.
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
The default values match those of RouterOS 7.11 on a Mikrotik
RB924i-2nD-BT5&BG77 ("Knot").
Upstream documentation: https://help.mikrotik.com/docs/display/ROS/PPP
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
RouterOS 7.7 added a `mode` parameter to the IPv4 neighbor discovery
configuration.
Changelog: https://forum.mikrotik.com/viewtopic.php?t=192427
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
The default values match those of RouterOS 7.11 on a Mikrotik
RB924i-2nD-BT5&BG77 ("Knot"). They're cross-checked with upstream
documentation[1].
[1] https://help.mikrotik.com/docs/display/ROS/Wireless+Interface
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
RouterOS 7.5 added `address-list` and `match-subdomain` as fields for
static DNS records.
Changelog: https://forum.mikrotik.com/viewtopic.php?t=188851
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Move the API data for `interface wireless security-profiles` to be in
order with the other entries for `interface wireless …`.
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
* Fixes#193: Add caps-man channel and caps-man manager interface
Adding the caps-man channel path from scratch.
Activating the caps-man manager interface path.
* Add changelog fragment and documentation for both paths
---------
Co-authored-by: Johannes Münch <git@washiza.eu>
* Fixes#191: Add path 'ip traffic-flow target'
* Fixes#191: Add changelog fragment
* Fixes#192: Change changetype from major to minor as it is only adding a path and neither breaking existing things nor adding completely new functionality
---------
Co-authored-by: Johannes Münch <git@washiza.eu>
* Fixes#179: Add missing /tool/e-mail parameter "tls"
In the
[documentation](https://help.mikrotik.com/docs/display/ROS/E-mail#Email-Properties) the parameter "tls" is mentioned but it cannot be used. The old "start-tls" parameter is not mentioned there (only on the [old documentation](https://wiki.mikrotik.com/wiki/Manual:Tools/email#Properties)).
Trying to use the paramter "tls" lead to the erro message `FAILED! => {"changed": false, "msg": "Unknown key \"tls\"."}`.
* Add changelog fragment
* Update changelogs/fragments/180-fix-tls-in-tool-email.yml
As suggested by felixfontein
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Johannes Münch <git@washiza.eu>
Co-authored-by: Felix Fontein <felix@fontein.de>
* add support to disable ipv6
* Add changelogs fragment
* Update changelogs/fragments/158-ipv6_settings-disable.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
* API_DATA > ('ip', 'dhcp-server', 'network') > netmask
replace "automatically_computed_from" by 'can_disable=True, remove_value=0'
automatically_computed_from does not seem to be used at any place in the code
without 'can_disable=True, remove_value=0' task is marked as changed at each execution.
* API_DATA > ('ip', 'dhcp-server', 'network') > next-server
replace "default=''" by 'can_disable=True'
The default in routeros is "no value" and it was not possible to remove a configured next-server
* API_DATA > ('ip', 'dhcp-server', 'network') > gateway
replace "automatically_computed_from" by "default=''"
automatically_computed_from does not seem to be used
* API_DATA > ('ip', 'dhcp-server', 'network') > dns-none
replace "default=''" by "default=False"
* Add changelogs fragment
* Update changelogs/fragments/156-ip_dhcp-server_network.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
* API update
Signed-off-by: Tomas Herfert <herfik>
* fix changelog fragment directory
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
Co-authored-by: Tomas Herfert <herfik>
* Add regexp field to "ip dns static"
* Change test_invalid_required_missing to use "ip dhcp-server"
"ip dns static" requires name or regexp so it cannot be used in this test.
* Add required_one_of attribute to APIData
Used by "ip dns static" which requires either "name" or "regexp.
* Add mutually_exclusive attribute to APIData
Used by "ip dns static" where only one of "name" or "regexp" can be used.
* Add changelog fragment
* support for "interface ethernet poe" and "interface vrrp"
Signed-off-by: Tomas Herfert <herfik>
* support "interface gre6" path
Signed-off-by: Tomas Herfert <herfik>
* ip dhcp-server - fix
Signed-off-by: Tomas Herfert <herfik>
* docs & changelog
Signed-off-by: Tomas Herfert <herfik>
* support for "interface ethernet poe" and "interface vrrp"
Signed-off-by: Tomas Herfert <herfik>
* support "interface gre6" path
Signed-off-by: Tomas Herfert <herfik>
* ip dhcp-server - fix
Signed-off-by: Tomas Herfert <herfik>
* docs & changelog
Signed-off-by: Tomas Herfert <herfik>
* Apply suggestions from code review
Co-authored-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Tomas Herfert <herfik>
Co-authored-by: Tomas Herfert <herfik>
Co-authored-by: Felix Fontein <felix@fontein.de>
* support for new API paths and few updates
Signed-off-by: Tomas Herfert <herfik>
* changelog fix
Signed-off-by: Tomas Herfert <herfik>
* tests update
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
Co-authored-by: Tomas Herfert <herfik>
* adding support for api fields that can be disabled and have default value at the same time
Signed-off-by: Tomas Herfert <herfik>
* api path support: interface gre
Signed-off-by: Tomas Herfert <herfik>
* docs
Signed-off-by: Tomas Herfert <herfik>
* unit test update & yamlling fix
Signed-off-by: Tomas Herfert <herfik>
* test fix
Signed-off-by: Tomas Herfert <herfik>
* sanity fix
Signed-off-by: Tomas Herfert <herfik>
* changelog
Signed-off-by: Tomas Herfert <herfik>
* Update per suggestion
Co-authored-by: Felix Fontein <felix@fontein.de>
* api path support: interface eoip
Signed-off-by: Tomas Herfert <herfik>
* docs
Signed-off-by: Tomas Herfert <herfik>
* apply suggestion from code review
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
Co-authored-by: Tomas Herfert <herfik>
Co-authored-by: Felix Fontein <felix@fontein.de>
* multiple api paths support and updates
Signed-off-by: Tomas Herfert <herfik>
* sanity fix
Signed-off-by: Tomas Herfert <herfik>
* another sanity fix
Signed-off-by: Tomas Herfert <herfik>
* Apply suggestions from code review
Co-authored-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Tomas Herfert <herfik>
Co-authored-by: Tomas Herfert <herfik>
Co-authored-by: Felix Fontein <felix@fontein.de>
* api path support: system logging action
Signed-off-by: Tomas Herfert <herfik>
* api path support: system logging
Signed-off-by: Tomas Herfert <herfik>
* docs & changelog
Signed-off-by: Tomas Herfert <herfik>
* typo fix
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
Co-authored-by: Tomas Herfert <herfik>
* adding api path interface pppoe-client
Signed-off-by: Tomas Herfert <herfik>
* support for api path interface vlan
Signed-off-by: Tomas Herfert <herfik>
* support for api path interface bridge vlan
Signed-off-by: Tomas Herfert <herfik>
* PR ID update
Signed-off-by: Tomas Herfert <herfik>
* typo fix
Signed-off-by: Tomas Herfert <herfik>
* support for API path interface bridge and update of interface bridge port ingress-filtering to True
Signed-off-by: Tomas Herfert <herfik>
* Apply suggestion per code review
Signed-off-by: Tomas Herfert <herfik>
* Update changelogs/fragments/125-api.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Tomas Herfert <herfik>
Co-authored-by: Tomas Herfert <herfik>
Co-authored-by: Felix Fontein <felix@fontein.de>
