* API update
Signed-off-by: Tomas Herfert <herfik>
* fix changelog fragment directory
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
Co-authored-by: Tomas Herfert <herfik>
* Add regexp field to "ip dns static"
* Change test_invalid_required_missing to use "ip dhcp-server"
"ip dns static" requires name or regexp so it cannot be used in this test.
* Add required_one_of attribute to APIData
Used by "ip dns static" which requires either "name" or "regexp.
* Add mutually_exclusive attribute to APIData
Used by "ip dns static" where only one of "name" or "regexp" can be used.
* Add changelog fragment
* support for "interface ethernet poe" and "interface vrrp"
Signed-off-by: Tomas Herfert <herfik>
* support "interface gre6" path
Signed-off-by: Tomas Herfert <herfik>
* ip dhcp-server - fix
Signed-off-by: Tomas Herfert <herfik>
* docs & changelog
Signed-off-by: Tomas Herfert <herfik>
* support for "interface ethernet poe" and "interface vrrp"
Signed-off-by: Tomas Herfert <herfik>
* support "interface gre6" path
Signed-off-by: Tomas Herfert <herfik>
* ip dhcp-server - fix
Signed-off-by: Tomas Herfert <herfik>
* docs & changelog
Signed-off-by: Tomas Herfert <herfik>
* Apply suggestions from code review
Co-authored-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Tomas Herfert <herfik>
Co-authored-by: Tomas Herfert <herfik>
Co-authored-by: Felix Fontein <felix@fontein.de>
* support for new API paths and few updates
Signed-off-by: Tomas Herfert <herfik>
* changelog fix
Signed-off-by: Tomas Herfert <herfik>
* tests update
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
Co-authored-by: Tomas Herfert <herfik>
* adding support for api fields that can be disabled and have default value at the same time
Signed-off-by: Tomas Herfert <herfik>
* api path support: interface gre
Signed-off-by: Tomas Herfert <herfik>
* docs
Signed-off-by: Tomas Herfert <herfik>
* unit test update & yamlling fix
Signed-off-by: Tomas Herfert <herfik>
* test fix
Signed-off-by: Tomas Herfert <herfik>
* sanity fix
Signed-off-by: Tomas Herfert <herfik>
* changelog
Signed-off-by: Tomas Herfert <herfik>
* Update per suggestion
Co-authored-by: Felix Fontein <felix@fontein.de>
* api path support: interface eoip
Signed-off-by: Tomas Herfert <herfik>
* docs
Signed-off-by: Tomas Herfert <herfik>
* apply suggestion from code review
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
Co-authored-by: Tomas Herfert <herfik>
Co-authored-by: Felix Fontein <felix@fontein.de>
* make api_modify to ignore builtin items
Signed-off-by: Tomas Herfert <herfik>
* include_builtin parametr for api_info module
Signed-off-by: Tomas Herfert <herfik>
* api_info ignore_builtin changelog
Signed-off-by: Tomas Herfert <herfik>
* typo
Signed-off-by: Tomas Herfert <herfik>
* Apply suggestions from code review
Co-authored-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Tomas Herfert <herfik>
Co-authored-by: Tomas Herfert <herfik>
Co-authored-by: Felix Fontein <felix@fontein.de>
* multiple api paths support and updates
Signed-off-by: Tomas Herfert <herfik>
* sanity fix
Signed-off-by: Tomas Herfert <herfik>
* another sanity fix
Signed-off-by: Tomas Herfert <herfik>
* Apply suggestions from code review
Co-authored-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Tomas Herfert <herfik>
Co-authored-by: Tomas Herfert <herfik>
Co-authored-by: Felix Fontein <felix@fontein.de>
* api path support: system logging action
Signed-off-by: Tomas Herfert <herfik>
* api path support: system logging
Signed-off-by: Tomas Herfert <herfik>
* docs & changelog
Signed-off-by: Tomas Herfert <herfik>
* typo fix
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
Co-authored-by: Tomas Herfert <herfik>
* adding api path interface pppoe-client
Signed-off-by: Tomas Herfert <herfik>
* support for api path interface vlan
Signed-off-by: Tomas Herfert <herfik>
* support for api path interface bridge vlan
Signed-off-by: Tomas Herfert <herfik>
* PR ID update
Signed-off-by: Tomas Herfert <herfik>
* typo fix
Signed-off-by: Tomas Herfert <herfik>
* support for API path interface bridge and update of interface bridge port ingress-filtering to True
Signed-off-by: Tomas Herfert <herfik>
* Apply suggestion per code review
Signed-off-by: Tomas Herfert <herfik>
* Update changelogs/fragments/125-api.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Tomas Herfert <herfik>
Co-authored-by: Tomas Herfert <herfik>
Co-authored-by: Felix Fontein <felix@fontein.de>
* interface list & member
Signed-off-by: Tomas Herfert <herfik>
* adding changelog fragment
Signed-off-by: Tomas Herfert <herfik>
* changelog fix
Signed-off-by: Tomas Herfert <herfik>
* sanity fix
Signed-off-by: Tomas Herfert <herfik>
* Apply suggestions from code review
Co-authored-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Tomas Herfert <herfik>
Co-authored-by: Tomas Herfert <herfik>
Co-authored-by: Felix Fontein <felix@fontein.de>
* Add api_info and api_modify modules.
* Add documentation, and cross-references for the modules.
* Bump version added for new modules.
* Ignore dynamic entries. Allow _info module to return them.
* Document behavior for dynamic entries.
* Update license headers.
* Add disclaimer.
* Improve formulation.
* Auto-generate path list in DOCUMENTATION.
* Add test to make sure lists have been generated automatically.
* update query to accept multiple librouteros ADN parameters
* update query for new yml strucutre
* add extended_query as separate function:(code in progress)
* extended_query main code is ready for review
* add changelog #63
* small fix for code indentation
* fix pep
* clear all pep issues
* extended_query ready for review (new yml structure)
* small doc fix for std query
* Update changelogs/fragments/63-add-extended_query.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update changelogs/fragments/63-add-extended_query.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update argument spec.
* Other suggestions.
* Fix syntax errors ('is' and 'or' are keywords).
* Make everything work again.
* Add docs, simplify code.
* Add some first tests.
* Do not add fake message when there is no search result.
* Improve tests.
* Fix tests.
* update extened query docs and ros api module examples
* fix pep plugins/modules/api.py:154:1: W293: blank line contains whitespace
* fix extended query example intend
* Update plugins/modules/api.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update plugins/modules/api.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* fix example docs
Co-authored-by: dako <dako@syslin.sof.dachev.lan>
Co-authored-by: Felix Fontein <felix@fontein.de>
* Add API docs fragment.
* Improve documentation.
* Move API code to api module_utils.
* Improve docs.
* Add api_facts module.
Does not yet support 'config'. I'm not sure whether that's actually
possible with the API.
* Convert subnet to integer if possible.
* Cleanup.
* Linting and fix tests.
* Remove things that make no sense.
* Simplify code.
* Add basic tests.
* Lint.
* fix issues #67
* fix query id check
* add changelog fragment
* fix changelog fragment new line
* fix changelog fragment new line2
* Update changelogs/fragments/68-fix-query-id-check.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
* Move splitting code to own file.
* Move list to dictionary code to quoting as well.
* Add quoting functionality.
* Add quoting filters.
* Add integration tests to CI.
* Fix bugs, increase coverage.
* Make parsing more strict.
* Extract function parse_argument_value from split_routeros_command to make proper parsing of WHERE possible.
* Adjust expected error message in integration tests.
* Simplify code and improve coverage.
* Add changelog fragment for WHERE strictness in api module.
* Add documenation.
* Fix typo.
* Add documentation references.
* Add example to api module which uses quote_argument_value.
* Fix bug, and add tests which prevent this in the future.
* Add more escape sequence tests.
* Make sure all control characters are quoted.
* fix(api): fixed a bug when splitting the argument string
* fix(api): added the shlex module for splitting
* fix(api): added the shlex module for splitting
* fix(api): moved shlex.split to self method split_params
* Fix indentation.
* Implement custom splitting algorithm.
* Raise AssertionError in case of internal error.
* Update plugins/modules/api.py
this is correct thanks !
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Nikolay Dachev <nikolay@dachev.info>
* Allow api module to fail.
* Improve error handling.
* Fix api unit tests.
* Add very basic tests of return values.
* Update api.py
fix ignoring the Fail task if we get TrapError
* Do not mangle fail result, and adjust tests.
* Improve changelog fragment.
* Reclassify changelog fragment as minor_changes, improve text.
* Mark changelog as 'breaking change'.
Co-authored-by: Nikolay Dachev <nikolay@dachev.info>
* Add options to control certificate validation for api module.
* Linting.
* Extend documentation.
* Fix validate_cert_hostname=true.
* Add documentation on setting up certificates on a RouterOS device.
* Disable use of depricated Ciphers
Old ciphers shouldn't be used. Devices that use newer ciphers couldn't be reached as the cipher was locked to sslv3.
* chore: add changelog fragment
* allow nonverbose idempotent config
* nonverbose config output
* typpo
* typpo
* release fragment
* config extra fact
* add fact ansible_net_config_nonverbose
* unit tests
* changelog fragments
* remove version fragment
* remove extra debug printf()
* update chlog fragment
* corrections for upstream pull request
* corrections for upstream pull request
* typo in changelog fragment
Co-authored-by: Felix Fontein <felix@fontein.de>
* typo in filename
Co-authored-by: Petr Klima <petr.klima@madeta.cz>
Co-authored-by: Felix Fontein <felix@fontein.de>
* Set export on Config to verbose
SUMMARY
In the configuration export session i think that using /export verbose is better than just /export, because with export only some configurations sections are going to be missed like BGP configuration, as proposed in https://github.com/ansible/ansible/pull/67868
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
facts.py
ADDITIONAL INFORMATION
extract of the output with /export verbose
# software id =
#
#
#
/interface ethernet
set [ find default-name=ether1 ] advertise=\
10M-half,10M-full,100M-half,100M-full,1000M-full arp=enabled arp-timeout=\
auto auto-negotiation=yes cable-settings=default disable-running-check=\
yes disabled=no full-duplex=yes loop-protect=default \
loop-protect-disable-time=5m loop-protect-send-interval=5s mac-address=\
50:00:00:02:00:00 mtu=1500 name=ether1 orig-mac-address=50:00:00:02:00:00 \
rx-flow-control=off speed=1Gbps tx-flow-control=off
set [ find default-name=ether2 ] advertise=\
10M-half,10M-full,100M-half,100M-full,1000M-full arp=enabled arp-timeout=\
auto auto-negotiation=yes cable-settings=default disable-running-check=\
yes disabled=no full-duplex=yes loop-protect=default \
loop-protect-disable-time=5m loop-protect-send-interval=5s mac-address=\
50:00:00:02:00:01 mtu=1500 name=ether2 orig-mac-address=50:00:00:02:00:01 \
rx-flow-control=off speed=1Gbps tx-flow-control=off
set [ find default-name=ether3 ] advertise=\
.....
.....
Extract of Output with only /export:
# software id =
#
#
#
/interface wireless security-profiles
set [ find default=yes ] supplicant-identity=MikroTik
/ip dhcp-client
add dhcp-options=hostname,clientid disabled=no interface=ether1
<END>
* Create 104_facts_export_verbose
* Update changelogs/fragments/104_facts_export_verbose
Co-authored-by: Felix Fontein <felix@fontein.de>
* Rename export to export_verbose
* Rename 104_facts_export_verbose to 104_facts_export_verbose.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* add api.py
* fix yaml
* query doc fix
* query doc fix
* fix exmaples
* dummy force retest
* fix small typo in RETURN
* remove no_log which conflict with routeros add param.
* fix pep8
* fix no_log conflict base on issue: password/pass no_log #49465
* ver 1.0.1
* small docs change
* more docs fix
* last one for docs change
* pip8 fix
* Update plugins/modules/api.py
I did not nice that .. Thank you!
Co-authored-by: Felix Fontein <felix@fontein.de>
* remove metadata block
* do not allow empty values to be added in execution path
* Update plugins/modules/api.py
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
* fixes for the last review
* Apply suggestions from code review
more fixes
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
* small changes in examples 'a' vs 'A'
* Apply suggestions from code review
more docs string fixes
Co-authored-by: Felix Fontein <felix@fontein.de>
* fixses in docs, reomve no_logs
* fix example vars
* fix again example a/A
* missing C in C()
* add external conn func
* fix pep8
* fix pep8 test2
* fix pep8 test3
* fix HAS_LIB
* return Ex as e
* fix pep8
* api unit test
* change unit test, change module structure
* pep8 fix
* more pep8
* some progress with unit test
* mm fix
* mock libros fix
* test
* try to fix mock
* test
* test mock
* more unit test
* libtoueros py3 only
* pytest importskyp added
* more unit test
* add update func unit test
* +more unit, fix mutually_exclusive
* fix missed , for module arg
* Apply suggestions from code review
typos fixes
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
* Update plugins/modules/api.py
will fix others as well
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
* fix docs
* small doc fix
* fix missing dots etc. in doc
* unit test completed
* reduce dummy Key func
* fix Key return
* final fix
* fix pep8
* fix pep8
Co-authored-by: root <root@syslin.sof.dachev.lan>
Co-authored-by: Nikolay Dachev <dako@Uranus.sof.dachev.lan>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
