mirror.MikroTik/ansible-collections.community.routeros
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.routeros.git synced 2025-08-18 16:48:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Set default value for interface list include/exclude (#394)
Some checks are pending
Collection Docs / Build Ansible Docs (push) Waiting to run
Details
Collection Docs / Publish Ansible Docs (push) Blocked by required conditions
Details
nox / Run extra sanity tests (push) Waiting to run
Details
nox / ansible-test (push) Waiting to run
Details

Browse source 
Without a default value a pre-existing value isn't removed unless the
caller specifies the property.
This commit is contained in:
hansmi 2025-08-17 12:55:56 +02:00 • committed by GitHub
parent db716c1368
commit fb070e4ac6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 4 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/394-iface-list-defaults.yml Normal file
View file

@ -0,0 +1,2 @@
minor_changes:
- api_info, api_modify - set default value for ``include`` and ``exclude`` properties in ``system note`` to an empty string (https://github.com/ansible-collections/community.routeros/pull/394).

4
plugins/module_utils/_api_data.py
View file

@ -441,8 +441,8 @@ PATHS = {
fully_understood=True, fully_understood=True,
fields={ fields={
'comment': KeyInfo(can_disable=True, remove_value=''), 'comment': KeyInfo(can_disable=True, remove_value=''),
'exclude': KeyInfo(), 'exclude': KeyInfo(default=''),
'include': KeyInfo(), 'include': KeyInfo(default=''),
'name': KeyInfo(), 'name': KeyInfo(),
}, },
), ),

8
tests/unit/plugins/modules/test_api_info.py
View file

@ -470,8 +470,6 @@ class TestRouterosApiInfoModule(ModuleTestCase):
{ {
'.id': '*2000010', '.id': '*2000010',
'name': 'WAN', 'name': 'WAN',
'include': '',
'exclude': '',
'comment': 'defconf', 'comment': 'defconf',
}, },
]) ])
@ -523,24 +521,18 @@ class TestRouterosApiInfoModule(ModuleTestCase):
{ {
'.id': '*2000000', '.id': '*2000000',
'name': 'all', 'name': 'all',
'include': '',
'exclude': '',
'builtin': True, 'builtin': True,
'comment': 'contains all interfaces', 'comment': 'contains all interfaces',
}, },
{ {
'.id': '*2000001', '.id': '*2000001',
'name': 'none', 'name': 'none',
'include': '',
'exclude': '',
'builtin': True, 'builtin': True,
'comment': 'contains no interfaces', 'comment': 'contains no interfaces',
}, },
{ {
'.id': '*2000010', '.id': '*2000010',
'name': 'WAN', 'name': 'WAN',
'include': '',
'exclude': '',
'builtin': False, 'builtin': False,
'comment': 'defconf', 'comment': 'defconf',
}, },