mirror.MikroTik/ansible-collections.community.routeros
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.routeros.git synced 2025-06-22 09:53:32 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Improve tests (#348)

Browse source 
* Simplify filter error tests.

* Convert set_module_args to context manager.
This commit is contained in:
Felix Fontein 2025-03-07 20:45:39 +01:00 • committed by GitHub
parent 6aaead1d4a
commit be9a7ed3ad
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 234 additions and 231 deletions
Download patch file Download diff file Expand all files Collapse all files

76
tests/unit/plugins/modules/test_api.py
View file

@ -34,8 +34,8 @@ class TestRouterosApiModule(ModuleTestCase):
def test_module_fail_when_required_args_missing(self):
with self.assertRaises(AnsibleFailJson) as exc:
set_module_args({})
self.module.main()
with set_module_args({}):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['failed'], True)
@ -43,8 +43,8 @@ class TestRouterosApiModule(ModuleTestCase):
@patch('ansible_collections.community.routeros.plugins.modules.api.ROS_api_module.api_add_path', new=fake_ros_api.path)
def test_api_path(self):
with self.assertRaises(AnsibleExitJson) as exc:
set_module_args(self.config_module_args.copy())
self.module.main()
with set_module_args(self.config_module_args.copy()):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['changed'], False)
@ -54,8 +54,8 @@ class TestRouterosApiModule(ModuleTestCase):
with self.assertRaises(AnsibleExitJson) as exc:
module_args = self.config_module_args.copy()
module_args['add'] = "name=unit_test_brige"
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['changed'], True)
@ -65,8 +65,8 @@ class TestRouterosApiModule(ModuleTestCase):
with self.assertRaises(AnsibleFailJson) as exc:
module_args = self.config_module_args.copy()
module_args['add'] = "name=unit_test_brige_exist"
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['failed'], True)
@ -77,8 +77,8 @@ class TestRouterosApiModule(ModuleTestCase):
with self.assertRaises(AnsibleExitJson) as exc:
module_args = self.config_module_args.copy()
module_args['remove'] = "*A1"
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['changed'], True)
@ -88,8 +88,8 @@ class TestRouterosApiModule(ModuleTestCase):
with self.assertRaises(AnsibleFailJson) as exc:
module_args = self.config_module_args.copy()
module_args['remove'] = "*A2"
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['failed'], True)
@ -100,8 +100,8 @@ class TestRouterosApiModule(ModuleTestCase):
with self.assertRaises(AnsibleExitJson) as exc:
module_args = self.config_module_args.copy()
module_args['cmd'] = "add name=unit_test_brige_arbitrary"
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['changed'], False)
@ -111,8 +111,8 @@ class TestRouterosApiModule(ModuleTestCase):
with self.assertRaises(AnsibleFailJson) as exc:
module_args = self.config_module_args.copy()
module_args['cmd'] = "add NONE_EXIST=unit_test_brige_arbitrary"
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['failed'], True)
@ -123,8 +123,8 @@ class TestRouterosApiModule(ModuleTestCase):
with self.assertRaises(AnsibleExitJson) as exc:
module_args = self.config_module_args.copy()
module_args['update'] = ".id=*A1 name=unit_test_brige"
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['changed'], True)
@ -134,8 +134,8 @@ class TestRouterosApiModule(ModuleTestCase):
with self.assertRaises(AnsibleFailJson) as exc:
module_args = self.config_module_args.copy()
module_args['update'] = ".id=*A2 name=unit_test_brige"
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['failed'], True)
@ -146,8 +146,8 @@ class TestRouterosApiModule(ModuleTestCase):
with self.assertRaises(AnsibleExitJson) as exc:
module_args = self.config_module_args.copy()
module_args['query'] = ".id name"
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['changed'], False)
@ -162,8 +162,8 @@ class TestRouterosApiModule(ModuleTestCase):
with self.assertRaises(AnsibleExitJson) as exc:
module_args = self.config_module_args.copy()
module_args['query'] = ".id other"
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['changed'], False)
@ -174,8 +174,8 @@ class TestRouterosApiModule(ModuleTestCase):
with self.assertRaises(AnsibleExitJson) as exc:
module_args = self.config_module_args.copy()
module_args['query'] = ".id name WHERE name == dummy_bridge_A2"
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['changed'], False)
@ -188,8 +188,8 @@ class TestRouterosApiModule(ModuleTestCase):
with self.assertRaises(AnsibleExitJson) as exc:
module_args = self.config_module_args.copy()
module_args['query'] = ".id name WHERE name != dummy_bridge_A2"
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['changed'], False)
@ -204,8 +204,8 @@ class TestRouterosApiModule(ModuleTestCase):
module_args['extended_query'] = {
'attributes': ['.id', 'name'],
}
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['changed'], False)
@ -222,8 +222,8 @@ class TestRouterosApiModule(ModuleTestCase):
module_args['extended_query'] = {
'attributes': ['.id', 'other'],
}
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['changed'], False)
@ -243,8 +243,8 @@ class TestRouterosApiModule(ModuleTestCase):
},
],
}
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['changed'], False)
@ -266,8 +266,8 @@ class TestRouterosApiModule(ModuleTestCase):
},
],
}
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['changed'], False)
@ -298,8 +298,8 @@ class TestRouterosApiModule(ModuleTestCase):
},
],
}
set_module_args(module_args)
self.module.main()
with set_module_args(module_args):
self.module.main()
result = exc.exception.args[0]
self.assertEqual(result['changed'], False)