From b499d9d7d90afd5bdd398250429f9915a8b7411c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Johannes=20M=C3=BCnch?= <derdeagle@users.noreply.github.com>
Date: Mon, 14 Oct 2024 20:50:36 +0200
Subject: [PATCH] Add new parameters from RouterOS 7.16 release (#323)

* Add new parameters from RouterOS 7.16 release

h3. /interface/bridge

- `forward-reserved-addresses` with default value `False`
- `max-learned-entries` with default value `auto`

h3. /ip/neighbor/discovery-settings

- `lldp-mac-phy-config` with default value `False` (from Router OS 7.15
release)
- `discover-interval` with default value `30s`
- `lldp-vlan-info` with default value `False`

h3. /ip/settings

- `ipv4-multipath-hash-policy` with default value `l3`

h3. /ipv6/settings

- `multipath-hash-policy` with default value `l3`

h3. /ip/dhcp-server/option

- `comment`

h3. /ip/dhcp-server/option/sets

- `comment`

h3. /ip/dhcp-server/matcher

- `comment`

h3. /tool/netwatch

- `acccept-icmp-time-exceeded` with default value `False`
- `ttl` with defaut value `255`

h3. /ip/service

- `max-sessions` with default value `20`

Add changelog fragment

* Update changelogs/fragments/323-add-ros-7.16-parameters.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
---
 .../fragments/323-add-ros-7.16-parameters.yml |  2 ++
 plugins/module_utils/_api_data.py             | 25 +++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100644 changelogs/fragments/323-add-ros-7.16-parameters.yml

diff --git a/changelogs/fragments/323-add-ros-7.16-parameters.yml b/changelogs/fragments/323-add-ros-7.16-parameters.yml
new file mode 100644
index 0000000..a88580d
--- /dev/null
+++ b/changelogs/fragments/323-add-ros-7.16-parameters.yml
@@ -0,0 +1,2 @@
+minor_changes:
+  - api_info, api_modify - add new parameters from the RouterOS 7.16 release (https://github.com/ansible-collections/community.routeros/pull/323).
diff --git a/plugins/module_utils/_api_data.py b/plugins/module_utils/_api_data.py
index a7985cf..847f5b1 100644
--- a/plugins/module_utils/_api_data.py
+++ b/plugins/module_utils/_api_data.py
@@ -262,6 +262,8 @@ PATHS = {
             versioned_fields=[
                 ([('7.0', '<')], 'ingress-filtering', KeyInfo(default=False)),
                 ([('7.0', '>=')], 'ingress-filtering', KeyInfo(default=True)),
+                ([('7.16', '>=')], 'forward-reserved-addresses', KeyInfo(default=False)),
+                ([('7.16', '>=')], 'max-learned-entries', KeyInfo(default='auto')),
             ],
             fields={
                 'admin-mac': KeyInfo(default=''),
@@ -1450,6 +1452,9 @@ PATHS = {
             fully_understood=True,
             versioned_fields=[
                 ([('7.7', '>=')], 'mode', KeyInfo(default='tx-and-rx')),
+                ([('7.15', '>=')], 'lldp-mac-phy-config', KeyInfo(default=False)),
+                ([('7.16', '>=')], 'discover-interval', KeyInfo(default='30s')),
+                ([('7.16', '>=')], 'lldp-vlan-info', KeyInfo(default=False)),
             ],
             fields={
                 'discover-interface-list': KeyInfo(),
@@ -1462,6 +1467,9 @@ PATHS = {
         unversioned=VersionedAPIData(
             single_value=True,
             fully_understood=True,
+            versioned_fields=[
+                ([('7.16', '>=')], 'ipv4-multipath-hash-policy', KeyInfo(default='l3')),
+            ],
             fields={
                 'accept-redirects': KeyInfo(default=False),
                 'accept-source-route': KeyInfo(default=False),
@@ -1498,6 +1506,9 @@ PATHS = {
         unversioned=VersionedAPIData(
             single_value=True,
             fully_understood=True,
+            versioned_fields=[
+                ([('7.16', '>=')], 'multipath-hash-policy', KeyInfo(default='l3')),
+            ],
             fields={
                 'accept-redirects': KeyInfo(default='yes-if-forwarding-disabled'),
                 'accept-router-advertisements': KeyInfo(default='yes-if-forwarding-disabled'),
@@ -2807,6 +2818,9 @@ PATHS = {
         unversioned=VersionedAPIData(
             fully_understood=True,
             primary_keys=('name',),
+            versioned_fields=[
+                ([('7.16', '>=')], 'comment', KeyInfo(can_disable=True, remove_value='')),
+            ],
             fields={
                 'code': KeyInfo(required=True),
                 'name': KeyInfo(),
@@ -2819,6 +2833,9 @@ PATHS = {
         unversioned=VersionedAPIData(
             fully_understood=True,
             primary_keys=('name',),
+            versioned_fields=[
+                ([('7.16', '>=')], 'comment', KeyInfo(can_disable=True, remove_value='')),
+            ],
             fields={
                 'name': KeyInfo(required=True),
                 'options': KeyInfo(),
@@ -2831,6 +2848,7 @@ PATHS = {
                 fully_understood=True,
                 primary_keys=('name', ),
                 versioned_fields=[
+                    ([('7.16', '>=')], 'comment', KeyInfo(can_disable=True, remove_value='')),
                     ([('7.16', '>=')], 'matching-type', KeyInfo()),
                 ],
                 fields={
@@ -4458,6 +4476,10 @@ PATHS = {
         versioned=[
             ('7', '>=', VersionedAPIData(
                 fully_understood=True,
+                versioned_fields=[
+                    ([('7.16', '>=')], 'accept-icmp-time-exceeded', KeyInfo(default=False)),
+                    ([('7.16', '>=')], 'ttl', KeyInfo(default=255)),
+                ],
                 fields={
                     'certificate': KeyInfo(),
                     'check-certificate': KeyInfo(),
@@ -5133,6 +5155,9 @@ PATHS = {
             fixed_entries=True,
             primary_keys=('name', ),
             fully_understood=True,
+            versioned_fields=[
+                ([('7.16', '>=')], 'max-sessions', KeyInfo(default=20)),
+            ],
             fields={
                 'address': KeyInfo(),
                 'certificate': KeyInfo(),