mirror.MikroTik/ansible-collections.community.routeros
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.routeros.git synced 2025-07-13 19:54:35 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix some bugs and adapt RouterOS v.7.12 changes (#234)

Browse source 
* Fix some bugs and adapt RouterOS v.7.12 changes

/ip traffic-flow target: make it a multiple value (single_value=False)
field
/routing id: add comment attribute
/tool e-mail: add versioning to the parameters as "address" was renamed to "server" in 7.12
/routing bgp connection: add missing attributes

* Add changelog fragment

* Fix duplicate key 'output.network'

* Split up the changelog fragment

---------

Co-authored-by: Johannes Münch <git@washiza.eu>
This commit is contained in:
derdeagle 2023-11-19 10:39:33 +01:00 • committed by GitHub
parent 479f3106bf
commit 92c6226394
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 76 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

5
changelogs/fragments/234-bugfixes-and-update-adaptations.yml Normal file
View file

@ -0,0 +1,5 @@
minor_changes:
- api_modify - add missing ``comment`` attribute to ``/routing id`` (https://github.com/ansible-collections/community.routeros/pull/234).
- api_modify - make ``/ip traffic-flow target`` a multiple value attribute (https://github.com/ansible-collections/community.routeros/pull/234).
- api_modify - add versioning to the ``/tool e-mail`` path (RouterOS 7.12 release) (https://github.com/ansible-collections/community.routeros/pull/234).
- api_modify - add missing attributes to the ``routing bgp connection`` path (https://github.com/ansible-collections/community.routeros/pull/234).

86
plugins/module_utils/_api_data.py
View file

@ -2390,7 +2390,7 @@ PATHS = {
), ),
('ip', 'traffic-flow', 'target'): APIData( ('ip', 'traffic-flow', 'target'): APIData(
unversioned=VersionedAPIData( unversioned=VersionedAPIData(
single_value=True, single_value=False,
fully_understood=True, fully_understood=True,
fields={ fields={
'address': KeyInfo(), 'address': KeyInfo(),
@ -2892,6 +2892,7 @@ PATHS = {
unversioned=VersionedAPIData( unversioned=VersionedAPIData(
fully_understood=True, fully_understood=True,
fields={ fields={
'comment': KeyInfo(can_disable=True, remove_value=''),
'disabled': KeyInfo(default=False), 'disabled': KeyInfo(default=False),
'id': KeyInfo(), 'id': KeyInfo(),
'name': KeyInfo(), 'name': KeyInfo(),
@ -3180,19 +3181,36 @@ PATHS = {
), ),
), ),
('tool', 'e-mail'): APIData( ('tool', 'e-mail'): APIData(
unversioned=VersionedAPIData( versioned=[
single_value=True, ('7.12', '>=', VersionedAPIData(
fully_understood=True, single_value=True,
fields={ fully_understood=True,
'address': KeyInfo(default='0.0.0.0'), fields={
'from': KeyInfo(default='<>'), 'from': KeyInfo(default='<>'),
'password': KeyInfo(default=''), 'password': KeyInfo(default=''),
'port': KeyInfo(default=25), 'port': KeyInfo(default=25),
'start-tls': KeyInfo(default=False), 'server': KeyInfo(default='0.0.0.0'),
'tls': KeyInfo(default=False), 'start-tls': KeyInfo(default=False),
'user': KeyInfo(default=''), 'tls': KeyInfo(default=False),
}, 'user': KeyInfo(default=''),
), 'vfr': KeyInfo(default=''),
},
)),
('7.12', '<', VersionedAPIData(
single_value=True,
fully_understood=True,
fields={
'address': KeyInfo(default='0.0.0.0'),
'from': KeyInfo(default='<>'),
'password': KeyInfo(default=''),
'port': KeyInfo(default=25),
'start-tls': KeyInfo(default=False),
'tls': KeyInfo(default=False),
'user': KeyInfo(default=''),
'vfr': KeyInfo(default=''),
},
)),
],
), ),
('tool', 'graphing'): APIData( ('tool', 'graphing'): APIData(
unversioned=VersionedAPIData( unversioned=VersionedAPIData(
@ -3552,20 +3570,58 @@ PATHS = {
fully_understood=True, fully_understood=True,
fields={ fields={
'as': KeyInfo(), 'as': KeyInfo(),
'name': KeyInfo(required=True), 'add-path-out': KeyInfo(),
'address-families': KeyInfo(),
'cisco-vpls-nlri-len-fmt': KeyInfo(),
'cluster-id': KeyInfo(),
'comment': KeyInfo(),
'connect': KeyInfo(default=True), 'connect': KeyInfo(default=True),
'disabled': KeyInfo(),
'hold-time': KeyInfo(),
'input.accept-communities': KeyInfo(),
'input.accept-ext-communities': KeyInfo(),
'input.accept-large-communities': KeyInfo(),
'input.accpet-nlri': KeyInfo(),
'input.accept-unknown': KeyInfo(),
'input.affinity': KeyInfo(),
'input.allow-as': KeyInfo(),
'input.filter': KeyInfo(),
'input.ignore-as-path-len': KeyInfo(),
'input.limit-process-routes-ipv4': KeyInfo(),
'input.limit-process-routes-ipv6': KeyInfo(),
'keepalive-time': KeyInfo(),
'listen': KeyInfo(default=True), 'listen': KeyInfo(default=True),
'local.address': KeyInfo(), 'local.address': KeyInfo(),
'local.port': KeyInfo(), 'local.port': KeyInfo(),
'local.role': KeyInfo(required=True), 'local.role': KeyInfo(required=True),
'local.ttl': KeyInfo(), 'local.ttl': KeyInfo(),
'multihop': KeyInfo(),
'name': KeyInfo(required=True),
'nexthop-choice': KeyInfo(),
'output.affinity': KeyInfo(),
'output.as-override': KeyInfo(),
'output.default-originate': KeyInfo(),
'output.default-prepend': KeyInfo(),
'output.filter-chain': KeyInfo(),
'output.filter-select': KeyInfo(),
'output.keep-sent-attributes': KeyInfo(),
'output.network': KeyInfo(),
'output.no-client-to-client-reflection': KeyInfo(),
'output.no-early-cut': KeyInfo(),
'output.redistribute': KeyInfo(),
'output.remote-private-as': KeyInfo(),
'remote.address': KeyInfo(required=True), 'remote.address': KeyInfo(required=True),
'remote.port': KeyInfo(), 'remote.port': KeyInfo(),
'remote.as': KeyInfo(), 'remote.as': KeyInfo(),
'remote.allowed-as': KeyInfo(), 'remote.allowed-as': KeyInfo(),
'remote.ttl': KeyInfo(), 'remote.ttl': KeyInfo(),
'router-id': KeyInfo(),
'routing-table': KeyInfo(),
'save-to': KeyInfo(),
'tcp-md5-key': KeyInfo(), 'tcp-md5-key': KeyInfo(),
'templates': KeyInfo(), 'templates': KeyInfo(),
'use-bfd': KeyInfo(),
'vrf': KeyInfo(),
}, },
), ),
), ),