From 873699631723bd6875b9292da7db9e0ea8642be5 Mon Sep 17 00:00:00 2001 From: hansmi Date: Thu, 13 Mar 2025 07:08:14 +0100 Subject: [PATCH] Change default for ddns-enabled to "auto" for RouterOS 7.17 and newer (#350) From the RouterOS 7.17 changelog: > *) cloud - changed ddns-enabled setting from "no" to "auto" (service > is enabled when BTH is enabled); `no` is not supported anymore, only `yes` and `auto` are. --- changelogs/fragments/350-ip-cloud-ddns-enabled-auto.yml | 2 ++ plugins/module_utils/_api_data.py | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/350-ip-cloud-ddns-enabled-auto.yml diff --git a/changelogs/fragments/350-ip-cloud-ddns-enabled-auto.yml b/changelogs/fragments/350-ip-cloud-ddns-enabled-auto.yml new file mode 100644 index 0000000..6d9d443 --- /dev/null +++ b/changelogs/fragments/350-ip-cloud-ddns-enabled-auto.yml @@ -0,0 +1,2 @@ +minor_changes: + - api_info, api_modify - change default for ``/ip/cloud/ddns-enabled`` for RouterOS 7.17 and newer from ``yes`` to ``auto`` (https://github.com/ansible-collections/community.routeros/pull/350). diff --git a/plugins/module_utils/_api_data.py b/plugins/module_utils/_api_data.py index 5ff335e..56e487a 100644 --- a/plugins/module_utils/_api_data.py +++ b/plugins/module_utils/_api_data.py @@ -2777,8 +2777,11 @@ PATHS = { unversioned=VersionedAPIData( single_value=True, fully_understood=True, + versioned_fields=[ + ([('7.17', '<')], 'ddns-enabled', KeyInfo(default=False)), + ([('7.17', '>=')], 'ddns-enabled', KeyInfo(default='auto')), + ], fields={ - 'ddns-enabled': KeyInfo(default=False), 'ddns-update-interval': KeyInfo(default='none'), 'update-time': KeyInfo(default=True), },