Remove unneccessary imports (#149)

* Remove unneccessary imports.

* Add noqas.

changelogs/fragments/remove-unneeded-imports.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - "various plugins and modules - remove unnecessary imports (https://github.com/ansible-collections/community.routeros/pull/149)."

plugins/cliconf/routeros.py

@@ -18,11 +18,8 @@ description:
 import re
 import json
 
-from itertools import chain
+from ansible.module_utils.common.text.converters import to_text
-
+from ansible.plugins.cliconf import CliconfBase
-from ansible.module_utils.common.text.converters import to_bytes, to_text
-from ansible_collections.ansible.netcommon.plugins.module_utils.network.common.utils import to_list
-from ansible.plugins.cliconf import CliconfBase, enable_mode
 
 
 class Cliconf(CliconfBase):

plugins/module_utils/api.py

@@ -12,14 +12,13 @@ __metaclass__ = type
 from ansible.module_utils.basic import missing_required_lib
 from ansible.module_utils.common.text.converters import to_native
 
-import re
 import ssl
 import traceback
 
 LIB_IMP_ERR = None
 try:
     from librouteros import connect
-    from librouteros.exceptions import LibRouterosError
+    from librouteros.exceptions import LibRouterosError  # noqa: F401, pylint: disable=unused-import
     HAS_LIB = True
 except Exception as e:
     HAS_LIB = False

plugins/modules/api.py

@@ -265,7 +265,6 @@ message:
 '''
 
 from ansible.module_utils.basic import AnsibleModule
-from ansible.module_utils.basic import missing_required_lib
 from ansible.module_utils.common.text.converters import to_native
 
 from ansible_collections.community.routeros.plugins.module_utils.quoting import (
@@ -282,8 +281,6 @@ from ansible_collections.community.routeros.plugins.module_utils.api import (
 )
 
 import re
-import ssl
-import traceback
 
 try:
     from librouteros.exceptions import LibRouterosError

plugins/modules/api_facts.py

@@ -178,7 +178,6 @@ ansible_facts:
       returned: I(gather_subset) contains C(routing)
       type: dict
 """
-import re
 
 from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.six import iteritems

plugins/modules/command.py

@@ -133,13 +133,11 @@ failed_conditions:
   sample: ['...', '...']
 """
 
-import re
 import time
 
 from ansible_collections.community.routeros.plugins.module_utils.routeros import run_commands
 from ansible_collections.community.routeros.plugins.module_utils.routeros import routeros_argument_spec
 from ansible.module_utils.basic import AnsibleModule
-from ansible_collections.ansible.netcommon.plugins.module_utils.network.common.utils import ComplexList
 from ansible_collections.ansible.netcommon.plugins.module_utils.network.common.parsing import Conditional
 from ansible.module_utils.six import string_types
 

plugins/terminal/routeros.py

@@ -5,11 +5,9 @@
 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 
-import json
 import re
 
 from ansible.errors import AnsibleConnectionFailure
-from ansible.module_utils.common.text.converters import to_text, to_bytes
 from ansible.plugins.terminal import TerminalBase
 from ansible.utils.display import Display