mirror.MikroTik/ansible-collections.community.routeros
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.routeros.git synced 2025-07-09 17:54:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Correction and Bugfix for ip dhcp-server network (#156)

Browse source 
* API_DATA > ('ip', 'dhcp-server', 'network') > netmask
replace "automatically_computed_from" by 'can_disable=True, remove_value=0'
automatically_computed_from does not seem to be used at any place in the code
without 'can_disable=True, remove_value=0' task is marked as changed at each execution.

* API_DATA > ('ip', 'dhcp-server', 'network') > next-server
replace "default=''" by 'can_disable=True'
The default in routeros is "no value" and it was not possible to remove a configured next-server

* API_DATA > ('ip', 'dhcp-server', 'network') > gateway
replace "automatically_computed_from" by "default=''"
automatically_computed_from does not seem to be used

* API_DATA > ('ip', 'dhcp-server', 'network') > dns-none
replace "default=''" by "default=False"

* Add changelogs fragment

* Update changelogs/fragments/156-ip_dhcp-server_network.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
phox142 2023-03-10 07:01:26 +01:00 • committed by GitHub
parent ab87a27018
commit 4d86ba1a7d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/156-ip_dhcp-server_network.yml Normal file
View file

@ -0,0 +1,2 @@
minor_changes:
- api_modify - adapt data for API paths ``ip dhcp-server network`` (https://github.com/ansible-collections/community.routeros/pull/156).

8
plugins/module_utils/_api_data.py
View file

@ -1356,12 +1356,12 @@ PATHS = {
'comment': KeyInfo(can_disable=True, remove_value=''), 'comment': KeyInfo(can_disable=True, remove_value=''),
'dhcp-option': KeyInfo(default=''), 'dhcp-option': KeyInfo(default=''),
'dhcp-option-set': KeyInfo(default=''), 'dhcp-option-set': KeyInfo(default=''),
'dns-none': KeyInfo(default=''), 'dns-none': KeyInfo(default=False),
'dns-server': KeyInfo(default=''), 'dns-server': KeyInfo(default=''),
'domain': KeyInfo(default=''), 'domain': KeyInfo(default=''),
'gateway': KeyInfo(automatically_computed_from=('address', )), 'gateway': KeyInfo(default=''),
'netmask': KeyInfo(automatically_computed_from=('address', )), 'netmask': KeyInfo(can_disable=True, remove_value=0),
'next-server': KeyInfo(default=''), 'next-server': KeyInfo(can_disable=True),
'ntp-server': KeyInfo(default=''), 'ntp-server': KeyInfo(default=''),
'wins-server': KeyInfo(default=''), 'wins-server': KeyInfo(default=''),
}, },