mirror.MikroTik/ansible-collections.community.routeros
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.routeros.git synced 2025-06-23 10:18:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix bug in preprocessing when wrapped line is appended to a non-existing entry. (#177)

Browse source
This commit is contained in:
Felix Fontein 2023-06-09 06:03:42 +02:00 • committed by GitHub
parent 2b8c66b983
commit 42ea132d60
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/177-facts-parsing.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- "facts - do not crash in CLI output preprocessing in unexpected situations during line unwrapping (https://github.com/ansible-collections/community.routeros/issues/170, https://github.com/ansible-collections/community.routeros/pull/177)."

4
plugins/modules/facts.py
View file

@ -391,7 +391,7 @@ class Interfaces(FactsBase):
for line in data.split('\n'):
if len(line) == 0 or line[:5] == 'Flags':
continue
elif not re.match(self.WRAPPED_LINE_RE, line):
elif not preprocessed or not re.match(self.WRAPPED_LINE_RE, line):
preprocessed.append(line)
else:
preprocessed[-1] += line
@ -468,7 +468,7 @@ class Routing(FactsBase):
for line in data.split('\n'):
if len(line) == 0 or line[:5] == 'Flags':
continue
elif not re.match(self.WRAPPED_LINE_RE, line):
elif not preprocessed or not re.match(self.WRAPPED_LINE_RE, line):
preprocessed.append(line)
else:
preprocessed[-1] += line