From 232a013c64dcd97806b0d4a84d43903ecdfb2eca Mon Sep 17 00:00:00 2001 From: Maurizio Pasquinelli Date: Tue, 20 Feb 2024 20:29:41 +0100 Subject: [PATCH] Fix date removal in nonverbose config (#262) * Fix date removal in nonverbose config As in newer versions of RouterOS the date format is 2024-10-02 and no longer 2024/10/02, the regex did no longer match all cases. This is fixed. * Add changelog fragment --- changelogs/fragments/262-fix-date-removal.yml | 2 ++ plugins/modules/facts.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/262-fix-date-removal.yml diff --git a/changelogs/fragments/262-fix-date-removal.yml b/changelogs/fragments/262-fix-date-removal.yml new file mode 100644 index 0000000..d083a46 --- /dev/null +++ b/changelogs/fragments/262-fix-date-removal.yml @@ -0,0 +1,2 @@ +bugfixes: + - facts - fix date not getting removed for idempotent config export (https://github.com/ansible-collections/community.routeros/pull/262). diff --git a/plugins/modules/facts.py b/plugins/modules/facts.py index a47e354..50f9a21 100644 --- a/plugins/modules/facts.py +++ b/plugins/modules/facts.py @@ -311,7 +311,7 @@ class Config(FactsBase): '/export', ] - RM_DATE_RE = re.compile(r'^# [a-z0-9/][a-z0-9/]* [0-9:]* by RouterOS') + RM_DATE_RE = re.compile(r'^# [a-z0-9/-][a-z0-9/-]* [0-9:]* by RouterOS') def populate(self): super(Config, self).populate()